Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gofumpt for v3 #1510

Closed
wants to merge 6 commits into from
Closed

gofumpt for v3 #1510

wants to merge 6 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented May 26, 2022

Description

Applies gofumpt to gaia v3 to make code easier to read

#1449 same


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release/v3.0.x@b1e0869). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release/v3.0.x    #1510   +/-   ##
=================================================
  Coverage                  ?   11.58%           
=================================================
  Files                     ?        8           
  Lines                     ?      673           
  Branches                  ?        0           
=================================================
  Hits                      ?       78           
  Misses                    ?      586           
  Partials                  ?        9           

@faddat
Copy link
Contributor Author

faddat commented May 26, 2022

Shall I fix docker, too?

@faddat
Copy link
Contributor Author

faddat commented May 26, 2022

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@okwme
Copy link
Contributor

okwme commented Jun 21, 2022

same as per comment from #1509:

opened a new issue related to stable release policy (#1549).
appreciate the work @faddat but these changes don't make sense to merge into those versions unless they're going to be part of a new release of those versions and EOL should only be bypassed by security updates.

@okwme okwme closed this Jun 21, 2022
@faddat
Copy link
Contributor Author

faddat commented Jul 2, 2022

Except that legibility & standardization is a security update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants