Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset ldflags for builds #147

Merged
merged 3 commits into from
Oct 18, 2019

Conversation

captain-kark
Copy link

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work. (minor docs PR, can be closed directly if needed)

  • Wrote tests (minor docs PR, no test impact)

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

docs/installation.md Outdated Show resolved Hide resolved
@alexanderbez
Copy link
Contributor

@captain-kark please target this PR towards master ;-)

@captain-kark captain-kark force-pushed the unset-LDFLAGS-for-builds branch from 06650af to a32f021 Compare October 1, 2019 13:30
@captain-kark captain-kark changed the base branch from release/v2.0.1 to master October 1, 2019 13:31
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACKd

@alexanderbez
Copy link
Contributor

@alessio do you know why CI is stuck?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants