-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unset ldflags for builds #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captain-kark
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
October 1, 2019 12:25
alexanderbez
reviewed
Oct 1, 2019
@captain-kark please target this PR towards |
captain-kark
force-pushed
the
unset-LDFLAGS-for-builds
branch
from
October 1, 2019 13:30
06650af
to
a32f021
Compare
alexanderbez
reviewed
Oct 1, 2019
alexanderbez
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
alessio
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACKd
@alessio do you know why CI is stuck? |
alessio
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.(minor docs PR, can be closed directly if needed)Wrote tests(minor docs PR, no test impact)Updated relevant documentation (
docs/
)Added a relevant changelog entry to theUnreleased
section inCHANGELOG.md
Reviewed
Files changed
in the github PR explorerFor Admin Use: