Upgrade golangci-lint to latest release (1.19.1)

[alessio]

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
• Wrote tests
• Updated relevant documentation (docs/)
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Reviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

[alexanderbez]

Instead of pinning to a specific version, why not just use go get ...@latest?

[alessio]

Instead of pinning to a specific version, why not just use go get ...@latest?

Thanks for the question @alexanderbez, I apologise for not providing a rationale beforehand. The reason behind this approach is that go getting golangci-lint would cause go.{mod,sum} to be polluted with dependencies that are not necessary to build gaia.

[alexanderbez]

Instead of pinning to a specific version, why not just use go get ...@latest?

Thanks for the question @alexanderbez, I apologise for not providing a rationale beforehand. The reason behind this approach is that go getting golangci-lint would cause go.{mod,sum} to be polluted with dependencies that are not necessary to build gaia.

Correct sir, hence for runsim we (cd /tmp && go get ...). We should do the same here.

[alessio]

I'm unsure. $TMPDIR is defined in Make's manual though it's on the makefile to ensure it exists beforehand. I've updated the installer script to automatically detect and download golangci-lint's latest release instead. Please have a look @alexanderbez

[codecov-io]

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   66.05%   66.05%           
=======================================
  Files           5        5           
  Lines         492      492           
=======================================
  Hits          325      325           
  Misses        136      136           
  Partials       31       31

[alexanderbez]

testedACK