Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quickstart for Mainnet Docs #1206

Merged
merged 5 commits into from
Feb 3, 2022
Merged

Add Quickstart for Mainnet Docs #1206

merged 5 commits into from
Feb 3, 2022

Conversation

glnro
Copy link
Contributor

@glnro glnro commented Jan 21, 2022

This PR includes a new 'quickstart for mainnet' guid per discussions in #1146. This additionally consolidates installation instructions from the mainnet repo docs update PR that's currently open. The mainnet repo will transition to an archive host and its new readme will reflect that instead of document installation/joining mainnet instructions.

This PR has a minor UI dependency to #1204

@glnro glnro added the scope: docs Improvements or additions to documentation label Jan 21, 2022
@glnro glnro requested a review from nooomski January 21, 2022 10:39
Copy link
Contributor

@nooomski nooomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions. Wondering if we should flip state sync & quicksync around so the easier option is the default one?

docs/getting-started/quickstart.md Outdated Show resolved Hide resolved
docs/getting-started/quickstart.md Outdated Show resolved Hide resolved
docs/getting-started/quickstart.md Outdated Show resolved Hide resolved
docs/getting-started/quickstart.md Outdated Show resolved Hide resolved
docs/getting-started/quickstart.md Outdated Show resolved Hide resolved
docs/getting-started/quickstart.md Show resolved Hide resolved
@glnro glnro force-pushed the glnro/quickstart-mainnet-docs branch 2 times, most recently from 7344c95 to 6935563 Compare January 27, 2022 14:03
@okwme
Copy link
Contributor

okwme commented Jan 28, 2022

does this require the update to the docs theme to allow for tabs before being merged?

@okwme
Copy link
Contributor

okwme commented Jan 28, 2022

the other PR got closed instead of merged? #1204

@nooomski
Copy link
Contributor

This script contains mistakes so should not be merged yet. Posting this on Testnet first (same script), but still need to go over some things.

lg added 4 commits February 2, 2022 20:51
Update quickstart docs

Update sync option copy

Co-authored-by: Noam <[email protected]>

Update min gas price

Co-authored-by: Noam <[email protected]>

Update min gas price

Co-authored-by: Noam <[email protected]>

Make requested changes

Update formatting
@glnro glnro force-pushed the glnro/quickstart-mainnet-docs branch from e297c9d to 5e6ec80 Compare February 2, 2022 19:51
Copy link
Contributor

@okwme okwme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@okwme okwme merged commit 1690e33 into main Feb 3, 2022
@okwme okwme deleted the glnro/quickstart-mainnet-docs branch February 3, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants