Fix broken and outdated links mentioned in recent github issues #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glnro
requested review from
alexanderbez,
cmwaters,
jackzampolin,
jgimeno,
okwme,
yaruwangway and
zmanian
as code owners
added 2 commits
December 23, 2021 18:22
nooomski
reviewed
Dec 23, 2021
| @@ -4,7 +4,7 @@ order: 3 | |||
|
|
|||
| # Join the Cosmos Hub Mainnet | |||
|
|
|||
| > Note: The current mainnet (`cosmoshub-4`) has performed the first [in-place store migration](https://docs.cosmos.network/v0.43/architecture/adr-041-in-place-store-migrations.html#adr-041-in-place-store-migrations) upgrade. That means that an [upgrade proposal](https://wallet.keplr.app/#/cosmoshub/governance?detailId=51) was passed to start using the [v5.0.0]() release of the gaia node. As a result the [v4.2.1](https://github.com/cosmos/gaia/releases/tag/v4.2.1) version of the gaia node would panic and stop at block [6910000](https://github.com/cosmos/gaia/blob/main/docs/migration/cosmoshub-4-delta-upgrade.md#Upgrade-will-take-place-July-12,-2021). At that point node operators installed the [v5.0.5](https://github.com/cosmos/gaia/releases/tag/v5.0.5) version of the gaia node and then started the node again. This type of upgrade preserves the same `chain-id` but is otherwise similar to a traditional hub upgrade, meaning historical state is lost after the upgrade takes place (still accessible of course by a v4.2.1 full node). | |||
| > Note: The current mainnet (`cosmoshub-4`) has performed the first [in-place store migration](https://github.com/cosmos/gaia/blob/main/docs/migration/cosmoshub-4-delta-upgrade.md) upgrade. That means that an [upgrade proposal](https://wallet.keplr.app/#/cosmoshub/governance?detailId=51) was passed to start using the [v5.0.0]() release of the gaia node. As a result the [v4.2.1](https://github.com/cosmos/gaia/releases/tag/v4.2.1) version of the gaia node would panic and stop at block [6910000](https://github.com/cosmos/gaia/blob/main/docs/migration/cosmoshub-4-delta-upgrade.md#Upgrade-will-take-place-July-12,-2021). At that point node operators installed the [v5.0.5](https://github.com/cosmos/gaia/releases/tag/v5.0.5) version of the gaia node and then started the node again. This type of upgrade preserves the same `chain-id` but is otherwise similar to a traditional hub upgrade, meaning historical state is lost after the upgrade takes place (still accessible of course by a v4.2.1 full node). | |||
There was a problem hiding this comment.
We should probably update this to vega
Comment on lines
+180
to
181
| View the status of the network with the [Cosmos Explorer](https://www.mintscan.io/cosmos). | ||
|
|
There was a problem hiding this comment.
Would suggest removing this line as it was just intended for when Cosmos launched.
Suggested change
| View the status of the network with the [Cosmos Explorer](https://www.mintscan.io/cosmos). |
| @@ -120,8 +120,7 @@ gaiad start | |||
|
|
|||
| Your node needs to know how to find peers. You'll need to add healthy seed nodes to `$HOME/.gaia/config/config.toml`. The [`launch`](https://github.com/cosmos/launch) repo contains links to some seed nodes. | |||
|
|
|||
| If those seeds aren't working, you can find more seeds and persistent peers on a Cosmos Hub explorer (a list can be found on the [launch page](https://cosmos.network/launch)). | |||
|
|
|||
| If those seeds aren't working, you can find more seeds and persistent peers on a Cosmos Hub explorer (try [mintscan](https://www.mintscan.io/cosmos) or [bigdipper](https://cosmos.bigdipper.live/)). The Hub team is currently working on a forthcoming guide with additional detail. | |||
There was a problem hiding this comment.
You can't actually find seed nodes on the explorers unfortunately. But quicksync has an address book you can download. @okwme are we OK to refer people to that? Centralisation and all that.
Suggested change
| If those seeds aren't working, you can find more seeds and persistent peers on a Cosmos Hub explorer (try [mintscan](https://www.mintscan.io/cosmos) or [bigdipper](https://cosmos.bigdipper.live/)). The Hub team is currently working on a forthcoming guide with additional detail. | |
| If those seeds aren't working, you can download an address book with more seeds and persistent peers on [QuickSync](https://quicksync.io/networks/cosmos.html) by ChainLayer. Please note that this is an external platform and that we encourage due diligence when adding untrusted peers. The Hub team is currently working on a forthcoming guide with additional details. |
There was a problem hiding this comment.
You can't actually find seed nodes on the explorers unfortunately. But quicksync has an address book you can download. @okwme are we OK to refer people to that? Centralisation and all that.
Not sure how well it's maintained, but there are seeds here too! https://github.com/cosmos/chain-registry/blob/master/cosmoshub/chain.json
There was a problem hiding this comment.
Ah yeah, that's a great one actually, forgot that, thanks Udit! I think we can go ahead and use those as well, the registry is being actively maintained and will hopefully be the main source for this seeds in the future.
Suggested change
| If those seeds aren't working, you can find more seeds and persistent peers on a Cosmos Hub explorer (try [mintscan](https://www.mintscan.io/cosmos) or [bigdipper](https://cosmos.bigdipper.live/)). The Hub team is currently working on a forthcoming guide with additional detail. | |
| If those seeds aren't working, you can use the [Cosmos Chain Registry](https://github.com/cosmos/chain-registry/blob/master/cosmoshub/chain.json) to find more. Alternatively, you can download an address book with more seeds and persistent peers on [QuickSync](https://quicksync.io/networks/cosmos.html) by ChainLayer. Please note that this is an external platform and that we encourage due diligence when adding untrusted peers. The Hub team is currently working on a forthcoming guide with additional details.``` |
|
Closing this and reopening a separate pr for the installation page as most of the issues were in the mainnet section that has been rewritten in #1146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the last few github issues have mentioned broken links or have referenced outdated links on the hub docs. This is by no means all of them but this is the first batch to be corrected.