-
Notifications
You must be signed in to change notification settings - Fork 717
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: add e2e test for ibc bypass msg (#2532)
* test: setup a new hermes instance * test: add executeHermesCommand * test: add hermesTransfer * test: add ibc-bypass-msg test * test: add hermes config * test: enable all e2e test * fix: tearDownSuite in e2e test * Apply suggestions from code review Co-authored-by: Simon Noetzlin <[email protected]> * update according to comments * chore: add comments to code * chore: correct typo * refactor bypass msg test * fix: parse query pending packet result * fix: format print error * fix: pending packets parsing * Apply suggestions from code review Co-authored-by: Philip Offtermatt <[email protected]> * docs: fix dead link * chore: fix lint * chore: lint fix * chore: lint fix1 * chore: remove nolint * Update tests/e2e/e2e_ibc_test.go --------- Co-authored-by: Simon Noetzlin <[email protected]> Co-authored-by: Philip Offtermatt <[email protected]>
- Loading branch information
3 people
authored and
lg
committed
Jun 30, 2023
1 parent
26cecb5
commit ac2baab
Showing
7 changed files
with
2,456 additions
and
2,022 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,98 +1,184 @@ | ||
| package e2e | ||
|
|
||
| // | ||
| // import ( | ||
| // "cosmossdk.io/math" | ||
| // sdk "github.com/cosmos/cosmos-sdk/types" | ||
| // distributiontypes "github.com/cosmos/cosmos-sdk/x/distribution/types" | ||
| //) | ||
| // | ||
| // "time" | ||
|
|
||
| // "cosmossdk.io/math" | ||
| // sdk "github.com/cosmos/cosmos-sdk/types" | ||
| // distributiontypes "github.com/cosmos/cosmos-sdk/x/distribution/types" | ||
| // ibcclienttypes "github.com/cosmos/ibc-go/v4/modules/core/02-client/types" | ||
| // ibcchanneltypes "github.com/cosmos/ibc-go/v4/modules/core/04-channel/types" | ||
| // ) | ||
|
|
||
| // func (s *IntegrationTestSuite) testBypassMinFeeWithdrawReward(endpoint string) { | ||
| // // submit gov prop to change bypass-msg param to MsgWithdrawDelegatorReward | ||
| // submitterAddr := s.chainA.validators[0].keyInfo.GetAddress() | ||
| // submitter := submitterAddr.String() | ||
| // proposalCounter++ | ||
| // s.govProposeNewBypassMsgs([]string{sdk.MsgTypeURL(&distributiontypes.MsgWithdrawDelegatorReward{})}, proposalCounter, submitter, standardFees.String()) | ||
| // | ||
| // paidFeeAmt := math.LegacyMustNewDecFromStr(minGasPrice).Mul(math.LegacyNewDec(gas)).String() | ||
| // payee := s.chainA.validators[0].keyInfo.GetAddress() | ||
| // | ||
| // testCases := []struct { | ||
| // name string | ||
| // fee string | ||
| // changeMaxBypassGasUsage bool | ||
| // expErr bool | ||
| // }{ | ||
| // { | ||
| // "bypass-msg with fee in the denom of global fee, pass", | ||
| // paidFeeAmt + uatomDenom, | ||
| // false, | ||
| // false, | ||
| // }, | ||
| // { | ||
| // "bypass-msg with zero coin in the denom of global fee, pass", | ||
| // "0" + uatomDenom, | ||
| // false, | ||
| // false, | ||
| // }, | ||
| // { | ||
| // "bypass-msg with zero coin not in the denom of global fee, pass", | ||
| // "0" + photonDenom, | ||
| // false, | ||
| // false, | ||
| // }, | ||
| // { | ||
| // "bypass-msg with non-zero coin not in the denom of global fee, fail", | ||
| // paidFeeAmt + photonDenom, | ||
| // false, | ||
| // true, | ||
| // }, | ||
| // { | ||
| // "bypass-msg with zero coin in the denom of global fee and maxTotalBypassMinFeeMsgGasUsage set to 1, fail", | ||
| // "0" + uatomDenom, | ||
| // true, | ||
| // true, | ||
| // }, | ||
| // { | ||
| // "bypass-msg with non zero coin in the denom of global fee and maxTotalBypassMinFeeMsgGasUsage set to 1, pass", | ||
| // paidFeeAmt + uatomDenom, | ||
| // false, | ||
| // false, | ||
| // }, | ||
| // } | ||
| // | ||
| // for _, tc := range testCases { | ||
| // | ||
| // if tc.changeMaxBypassGasUsage { | ||
| // proposalCounter++ | ||
| // // change MaxTotalBypassMinFeeMsgGasUsage through governance proposal from 1_000_0000 to 1 | ||
| // s.govProposeNewMaxTotalBypassMinFeeMsgGasUsage(1, proposalCounter, submitter) | ||
| // } | ||
| // | ||
| // // get delegator rewards | ||
| // rewards, err := queryDelegatorTotalRewards(endpoint, payee.String()) | ||
| // s.Require().NoError(err) | ||
| // | ||
| // // get delegator stake balance | ||
| // oldBalance, err := getSpecificBalance(endpoint, payee.String(), stakeDenom) | ||
| // s.Require().NoError(err) | ||
| // | ||
| // // withdraw rewards | ||
| // s.Run(tc.name, func() { | ||
| // s.execWithdrawAllRewards(s.chainA, 0, payee.String(), tc.fee, tc.expErr) | ||
| // }) | ||
| // | ||
| // if !tc.expErr { | ||
| // // get updated balance | ||
| // incrBalance, err := getSpecificBalance(endpoint, payee.String(), stakeDenom) | ||
| // s.Require().NoError(err) | ||
| // | ||
| // // compute sum of old balance and stake token rewards | ||
| // oldBalancePlusReward := rewards.GetTotal().Add(sdk.NewDecCoinFromCoin(oldBalance)) | ||
| // s.Require().Equal(oldBalancePlusReward[0].Denom, stakeDenom) | ||
| // | ||
| // // check updated balance got increased by at least oldBalancePlusReward | ||
| // s.Require().True(sdk.NewDecCoinFromCoin(incrBalance).IsGTE(oldBalancePlusReward[0])) | ||
| // } | ||
| // } | ||
| //} | ||
| // // submit gov prop to change bypass-msg param to MsgWithdrawDelegatorReward | ||
| // submitterAddr := s.chainA.validators[0].keyInfo.GetAddress() | ||
| // submitter := submitterAddr.String() | ||
| // proposalCounter++ | ||
| // s.govProposeNewBypassMsgs([]string{sdk.MsgTypeURL(&distributiontypes.MsgWithdrawDelegatorReward{})}, proposalCounter, submitter, standardFees.String()) | ||
|
|
||
| // paidFeeAmt := math.LegacyMustNewDecFromStr(minGasPrice).Mul(math.LegacyNewDec(gas)).String() | ||
| // payee := s.chainA.validators[0].keyInfo.GetAddress() | ||
|
|
||
| // testCases := []struct { | ||
| // name string | ||
| // fee string | ||
| // changeMaxBypassGasUsage bool | ||
| // expErr bool | ||
| // }{ | ||
| // { | ||
| // "bypass-msg with fee in the denom of global fee, pass", | ||
| // paidFeeAmt + uatomDenom, | ||
| // false, | ||
| // false, | ||
| // }, | ||
| // { | ||
| // "bypass-msg with zero coin in the denom of global fee, pass", | ||
| // "0" + uatomDenom, | ||
| // false, | ||
| // false, | ||
| // }, | ||
| // { | ||
| // "bypass-msg with zero coin not in the denom of global fee, pass", | ||
| // "0" + photonDenom, | ||
| // false, | ||
| // false, | ||
| // }, | ||
| // { | ||
| // "bypass-msg with non-zero coin not in the denom of global fee, fail", | ||
| // paidFeeAmt + photonDenom, | ||
| // false, | ||
| // true, | ||
| // }, | ||
| // { | ||
| // "bypass-msg with zero coin in the denom of global fee and maxTotalBypassMinFeeMsgGasUsage set to 1, fail", | ||
| // "0" + uatomDenom, | ||
| // true, | ||
| // true, | ||
| // }, | ||
| // { | ||
| // "bypass-msg with non zero coin in the denom of global fee and maxTotalBypassMinFeeMsgGasUsage set to 1, pass", | ||
| // paidFeeAmt + uatomDenom, | ||
| // false, | ||
| // false, | ||
| // }, | ||
| // } | ||
|
|
||
| // for _, tc := range testCases { | ||
|
|
||
| // if tc.changeMaxBypassGasUsage { | ||
| // proposalCounter++ | ||
| // // change MaxTotalBypassMinFeeMsgGasUsage through governance proposal from 1_000_0000 to 1 | ||
| // s.govProposeNewMaxTotalBypassMinFeeMsgGasUsage(1, proposalCounter, submitter) | ||
| // } | ||
|
|
||
| // // get delegator rewards | ||
| // rewards, err := queryDelegatorTotalRewards(endpoint, payee.String()) | ||
| // s.Require().NoError(err) | ||
|
|
||
| // // get delegator stake balance | ||
| // oldBalance, err := getSpecificBalance(endpoint, payee.String(), stakeDenom) | ||
| // s.Require().NoError(err) | ||
|
|
||
| // // withdraw rewards | ||
| // s.Run(tc.name, func() { | ||
| // s.execWithdrawAllRewards(s.chainA, 0, payee.String(), tc.fee, tc.expErr) | ||
| // }) | ||
|
|
||
| // if !tc.expErr { | ||
| // // get updated balance | ||
| // incrBalance, err := getSpecificBalance(endpoint, payee.String(), stakeDenom) | ||
| // s.Require().NoError(err) | ||
|
|
||
| // // compute sum of old balance and stake token rewards | ||
| // oldBalancePlusReward := rewards.GetTotal().Add(sdk.NewDecCoinFromCoin(oldBalance)) | ||
| // s.Require().Equal(oldBalancePlusReward[0].Denom, stakeDenom) | ||
|
|
||
| // // check updated balance got increased by at least oldBalancePlusReward | ||
| // s.Require().True(sdk.NewDecCoinFromCoin(incrBalance).IsGTE(oldBalancePlusReward[0])) | ||
| // } | ||
| // } | ||
| // } | ||
|
|
||
| // func (s *IntegrationTestSuite) testIBCBypassMsg() { | ||
| // // submit gov proposal to change bypass-msg param to | ||
| // // ["/ibc.core.channel.v1.MsgRecvPacket", | ||
| // // "/ibc.core.channel.v1.MsgAcknowledgement", | ||
| // // "/ibc.core.client.v1.MsgUpdateClient"] | ||
| // submitterAddr := s.chainA.validators[0].keyInfo.GetAddress() | ||
| // submitter := submitterAddr.String() | ||
| // proposalCounter++ | ||
| // s.govProposeNewBypassMsgs([]string{ | ||
| // sdk.MsgTypeURL(&ibcchanneltypes.MsgRecvPacket{}), | ||
| // sdk.MsgTypeURL(&ibcchanneltypes.MsgAcknowledgement{}), | ||
| // sdk.MsgTypeURL(&ibcclienttypes.MsgUpdateClient{}), | ||
| // }, proposalCounter, submitter, standardFees.String()) | ||
|
|
||
| // // use hermes1 to test default ibc bypass-msg | ||
| // // | ||
| // // test 1: transaction only contains bypass-msgs, pass | ||
| // s.testTxContainsOnlyIBCBypassMsg() | ||
| // // test 2: test transactions contains both bypass and non-bypass msgs (sdk.MsgTypeURL(&ibcchanneltypes.MsgTimeout{}) | ||
| // s.testTxContainsMixBypassNonBypassMsg() | ||
| // // test 3: test bypass-msgs exceed the MaxBypassGasUsage | ||
| // s.testBypassMsgsExceedMaxBypassGasLimit() | ||
|
|
||
| // // set the default bypass-msg back | ||
| // proposalCounter++ | ||
| // s.govProposeNewBypassMsgs([]string{ | ||
| // sdk.MsgTypeURL(&ibcchanneltypes.MsgRecvPacket{}), | ||
| // sdk.MsgTypeURL(&ibcchanneltypes.MsgAcknowledgement{}), | ||
| // sdk.MsgTypeURL(&ibcclienttypes.MsgUpdateClient{}), | ||
| // sdk.MsgTypeURL(&ibcchanneltypes.MsgTimeout{}), | ||
| // sdk.MsgTypeURL(&ibcchanneltypes.MsgTimeoutOnClose{}), | ||
| // }, proposalCounter, submitter, standardFees.String()) | ||
| // } | ||
|
|
||
| // func (s *IntegrationTestSuite) testTxContainsOnlyIBCBypassMsg() { | ||
| // s.T().Logf("testing transaction contains only ibc bypass messages") | ||
| // ok := s.hermesTransfer(hermesConfigWithGasPrices, s.chainA.id, s.chainB.id, transferChannel, uatomDenom, 100, 1000, 1) | ||
| // s.Require().True(ok) | ||
|
|
||
| // scrRelayerBalanceBefore, dstRelayerBalanceBefore := s.queryRelayerWalletsBalances() | ||
|
|
||
| // pass := s.hermesClearPacket(hermesConfigNoGasPrices, s.chainA.id, transferChannel) | ||
| // s.Require().True(pass) | ||
| // pendingPacketsExist := s.hermesPendingPackets(hermesConfigNoGasPrices, s.chainA.id, transferChannel) | ||
| // s.Require().False(pendingPacketsExist) | ||
|
|
||
| // // confirm relayer wallets do not pay fees | ||
| // scrRelayerBalanceAfter, dstRelayerBalanceAfter := s.queryRelayerWalletsBalances() | ||
| // s.Require().Equal(scrRelayerBalanceBefore.String(), scrRelayerBalanceAfter.String()) | ||
| // s.Require().Equal(dstRelayerBalanceBefore.String(), dstRelayerBalanceAfter.String()) | ||
| // } | ||
|
|
||
| // func (s *IntegrationTestSuite) testTxContainsMixBypassNonBypassMsg() { | ||
| // s.T().Logf("testing transaction contains both bypass and non-bypass messages") | ||
| // // hermesTransfer with --timeout-height-offset=1 | ||
| // ok := s.hermesTransfer(hermesConfigWithGasPrices, s.chainA.id, s.chainB.id, transferChannel, uatomDenom, 100, 1, 1) | ||
| // s.Require().True(ok) | ||
| // // make sure that the transaction is timeout | ||
| // time.Sleep(3 * time.Second) | ||
| // pendingPacketsExist := s.hermesPendingPackets(hermesConfigNoGasPrices, s.chainA.id, transferChannel) | ||
| // s.Require().True(pendingPacketsExist) | ||
|
|
||
| // pass := s.hermesClearPacket(hermesConfigNoGasPrices, s.chainA.id, transferChannel) | ||
| // s.Require().False(pass) | ||
| // // clear packets with paying fee, to not influence the next transaction | ||
| // pass = s.hermesClearPacket(hermesConfigWithGasPrices, s.chainA.id, transferChannel) | ||
| // s.Require().True(pass) | ||
| // } | ||
|
|
||
| // func (s *IntegrationTestSuite) testBypassMsgsExceedMaxBypassGasLimit() { | ||
| // s.T().Logf("testing bypass messages exceed MaxBypassGasUsage") | ||
| // ok := s.hermesTransfer(hermesConfigWithGasPrices, s.chainA.id, s.chainB.id, transferChannel, uatomDenom, 100, 1000, 12) | ||
| // s.Require().True(ok) | ||
| // pass := s.hermesClearPacket(hermesConfigNoGasPrices, s.chainA.id, transferChannel) | ||
| // s.Require().False(pass) | ||
|
|
||
| // pendingPacketsExist := s.hermesPendingPackets(hermesConfigNoGasPrices, s.chainA.id, transferChannel) | ||
| // s.Require().True(pendingPacketsExist) | ||
|
|
||
| // pass = s.hermesClearPacket(hermesConfigWithGasPrices, s.chainA.id, transferChannel) | ||
| // s.Require().True(pass) | ||
| // } |
Oops, something went wrong.