Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Fix failed to call EstimateGas #761

Merged
merged 14 commits into from
Feb 16, 2021
Merged

Conversation

KamiD
Copy link

@KamiD KamiD commented Jan 30, 2021

Closes: #760

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@KamiD KamiD requested review from fedekunze and noot as code owners January 30, 2021 09:12
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a test to check that this doesn't break in the future?

KamiD and others added 2 commits February 1, 2021 22:21
rpc: fix method to calculate block hash and fix mismatch block hash i…
Copy link
Contributor

@araskachoi araskachoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@araskachoi araskachoi merged commit fae8147 into cosmos:development Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to call function EstimateGas during deploy contract when account nonce 0 has deployed a contract
3 participants