Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

evm: fix begin and endblock #583

Merged
merged 7 commits into from
Oct 20, 2020
Merged

evm: fix begin and endblock #583

merged 7 commits into from
Oct 20, 2020

Conversation

fedekunze
Copy link
Contributor

No description provided.

@fedekunze fedekunze marked this pull request as ready for review October 19, 2020 11:40
@fedekunze fedekunze requested a review from noot as a code owner October 19, 2020 11:40
@fedekunze fedekunze requested a review from araskachoi October 19, 2020 11:43
@fedekunze fedekunze self-assigned this Oct 19, 2020
@fedekunze fedekunze added Type: Bug x/evm EVM module issues labels Oct 19, 2020
araskachoi
araskachoi approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@araskachoi araskachoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@fedekunze
Copy link
Contributor Author

@noot can you test the changes 🙏

@noot
Copy link
Contributor

noot commented Oct 20, 2020

seems to fix the bloom issue for me- could you update keeper.GetBlockBloom to return false if the bloom cannot be found?

	if !has {
		return ethtypes.Bloom{}, false 
	}

@fedekunze fedekunze merged commit d274c76 into development Oct 20, 2020
@fedekunze fedekunze deleted the fedekunze/fix-evm-blockers branch October 20, 2020 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noot noot noot approved these changes

@araskachoi araskachoi araskachoi approved these changes

Assignees

@fedekunze fedekunze

Labels
Type: Bug x/evm EVM module issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedekunze @noot @araskachoi