Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

fix retrieval of block 1, add another bloom test #310

Closed
wants to merge 2 commits into from

Conversation

noot
Copy link
Contributor

@noot noot commented May 21, 2020

Closes: #301 potentially #306

Description

  • fix TestBlockBloom_Hash

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@noot noot changed the title Noot/get block fix retrieval of block 1, add another bloom test May 21, 2020
@noot noot closed this Jun 8, 2020
@fedekunze fedekunze deleted the noot/get-block branch June 8, 2020 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test eth_getBlockByHash
1 participant