Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overwrite sequence and account-number flags when used with offline=false #9856

Merged
merged 35 commits into from
Aug 9, 2021

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #9784

Overwrite --sequence and --account-number flags by default flag values, when used with offline=false in sign-batch command.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 changed the title Likhita/overwrite sequence and account-number flags when used with offline=false fix: Likhita/overwrite sequence and account-number flags when used with offline=false Aug 5, 2021
@orijbot
Copy link

orijbot commented Aug 5, 2021

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #9856 (7ffb026) into master (f479b51) will increase coverage by 0.01%.
The diff coverage is 66.66%.

❗ Current head 7ffb026 differs from pull request most recent head 7b0e7a7. Consider uploading reports for the commit 7b0e7a7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9856      +/-   ##
==========================================
+ Coverage   63.45%   63.46%   +0.01%     
==========================================
  Files         568      568              
  Lines       53260    53275      +15     
==========================================
+ Hits        33795    33812      +17     
+ Misses      17543    17539       -4     
- Partials     1922     1924       +2     
Impacted Files Coverage Δ
x/auth/client/cli/tx_sign.go 0.00% <0.00%> (ø)
x/auth/client/testutil/suite.go 96.35% <100.00%> (+0.04%) ⬆️
client/keys/import.go 57.14% <0.00%> (-1.95%) ⬇️
client/keys/add.go 67.42% <0.00%> (ø)
client/context.go 57.22% <0.00%> (+1.01%) ⬆️
client/keys/export.go 73.21% <0.00%> (+8.92%) ⬆️

@likhita-809 likhita-809 marked this pull request as ready for review August 5, 2021 11:52
@amaury1093 amaury1093 changed the title fix: Likhita/overwrite sequence and account-number flags when used with offline=false fix: overwrite sequence and account-number flags when used with offline=false Aug 5, 2021
x/auth/client/cli/tx_sign.go Show resolved Hide resolved
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cyberbono3 cyberbono3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 9, 2021
@mergify mergify bot merged commit 59f63a2 into master Aug 9, 2021
@mergify mergify bot deleted the likhita/sequence-flag-ux-issue branch August 9, 2021 15:30
@amaury1093 amaury1093 mentioned this pull request May 23, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: make sequence flag work on its own
6 participants