-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: overwrite sequence and account-number flags when used with offline=false #9856
Conversation
…rn GasLeft on GasMeter
…khita/sequence-flag-ux-issue
…es when provided with offline != true
Visit https://dashboard.github.orijtech.com?pr=9856&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
Codecov Report
@@ Coverage Diff @@
## master #9856 +/- ##
==========================================
+ Coverage 63.45% 63.46% +0.01%
==========================================
Files 568 568
Lines 53260 53275 +15
==========================================
+ Hits 33795 33812 +17
+ Misses 17543 17539 -4
- Partials 1922 1924 +2
|
…khita/sequence-flag-ux-issue
…khita/sequence-flag-ux-issue
…osmos/cosmos-sdk into likhita/sequence-flag-ux-issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…khita/sequence-flag-ux-issue
…khita/sequence-flag-ux-issue
…khita/sequence-flag-ux-issue
…khita/sequence-flag-ux-issue
Description
Closes: #9784
Overwrite --sequence and --account-number flags by default flag values, when used with offline=false in sign-batch command.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change