-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ORM package DO NOT MERGE! #9491
Conversation
…khita/add-table-store
Codecov Report
@@ Coverage Diff @@
## master #9491 +/- ##
==========================================
+ Coverage 60.58% 60.89% +0.31%
==========================================
Files 589 601 +12
Lines 37218 37769 +551
==========================================
+ Hits 22548 23001 +453
- Misses 12726 12787 +61
- Partials 1944 1981 +37
|
…khita/add-table-store
This can only be merged after RC candidate is out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @likhita-809. This PR is pretty large. How do envision reviewers reviewing this PR effectively? Also, why are we adding an ORM to the SDK to begin with?
This PR is just about migrating the ORM package from regen-ledger to cosmos-sdk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs docs docs. Cant expect people to read the code to understand how to use this.
…khita/add-table-store
…osmos-sdk into likhita/add-table-store
…khita/add-table-store
…khita/add-table-store
…khita/add-table-store
…khita/add-table-store
@ryanchristo and @blushi will be coordinating to write-up docs. I do think it would be ideal to split this up into smaller PRs if possible. One challenge is that all of this code already did go through a few rounds of review outside the SDK when we created the group module, so I understand the motivation to pull it in all at once. But still piece by piece is probably better. What about putting this in the |
Also, doing this piece by piece will allow us to make some upgrades to the initial version. In particular, I'm thinking we might not want How about we start with a PR that just brings in the basic |
I believe that makes sense @aaronc |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@ryanchristo I believe we can keep this PR closed since it's just migrating the current version of the ORM package in one go and we don't wanna do that. |
ref: #9237