Fix init --recover not working #9201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiccardoM
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #9201 +/- ##
=======================================
Coverage 59.71% 59.71%
=======================================
Files 595 595
Lines 37317 37318 +1
=======================================
+ Hits 22283 22284 +1
Misses 13056 13056
Partials 1978 1978
|
alexanderbez
approved these changes
Apr 26, 2021
alessio
added
the
A:automerge
|
@robert-zaremba @AmauryM I think this can be added to |
|
@Mergifyio backport release/v0.42.x |
mergify bot
pushed a commit
that referenced
this pull request
Aug 4, 2021
…#9201) Co-authored-by: Alessio Treglia <[email protected]> (cherry picked from commit fdbc32e)
|
Command
|
robert-zaremba
pushed a commit
that referenced
this pull request
Aug 4, 2021
…#9201) (#9850) Co-authored-by: Alessio Treglia <[email protected]> (cherry picked from commit fdbc32e) Co-authored-by: Riccardo Montagnin <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Aug 4, 2021
…#9201) Co-authored-by: Alessio Treglia <[email protected]> (cherry picked from commit fdbc32e)
Raumo0
pushed a commit
to mapofzones/cosmos-sdk
that referenced
this pull request
Feb 13, 2022
* docs: add v0.43 release version option (backport cosmos#9506) (cosmos#9677) * docs: add v0.43 version option (cosmos#9506) Co-authored-by: ryanchrypto <[email protected]> (cherry picked from commit 325dabd) # Conflicts: # docs/versions * fix conflicts Co-authored-by: Ryan Christoffersen <[email protected]> Co-authored-by: Amaury M <[email protected]> * chore: Add missing entry in 0.42.7 Changelog (cosmos#9722) * fix: support output flag on tx commands (backport cosmos#9717) (cosmos#9772) * fix: support output flag on tx commands (cosmos#9717) <!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description Closes: cosmos#9684 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> * feat: Query txs by signature and by address+seq (backport cosmos#9750) (cosmos#9783) * feat: Query txs by signature and by address+seq (cosmos#9750) <!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description Closes: cosmos#9741 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> * fix: hardcoded ledger algo on `keys add` (backport cosmos#9766) (cosmos#9804) * fix: hardcoded ledger algo on `keys add` (cosmos#9766) <!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description Closes: cosmos#9734 cc: @jleni <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> * chore: Add Changelog and Release Notes for v0.42.8 (cosmos#9807) * chore: Add Changelog and Release Notes for v0.42.8 * Change date * feat: Improve withdraw-all-rewards UX (backport cosmos#9781) (cosmos#9825) * feat: Improve withdraw-all-rewards UX (cosmos#9781) ## Description Related to cosmos#9489, this PR improves the UX when using the `withdraw-all-rewards` command by forcing the broadcast mode to `block` if the chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (`sync` and `async`). * fix: Capability Issue on Restart, Backport to v0.42 (cosmos#9835) * implement BeginBlock fix * add changelog * fix lint * address reviews * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <[email protected]> * address reviews * Apply suggestions from code review Co-authored-by: Robert Zaremba <[email protected]> * move store check * add api breaking changelog * fix lint Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> * Fixed the --recover flag not working properly inside the init command (cosmos#9201) (cosmos#9850) Co-authored-by: Alessio Treglia <[email protected]> (cherry picked from commit fdbc32e) Co-authored-by: Riccardo Montagnin <[email protected]> * chore: prepare 0.42.9 release (cosmos#9852) * prepare 0.42.9 release * add 9201 to changelog Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Ryan Christoffersen <[email protected]> Co-authored-by: Amaury M <[email protected]> Co-authored-by: Aditya <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Riccardo Montagnin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
--recoverflag of theinitcommand. Previously, due to the fact that inside theifbody we used the samemnemonicname for the variable, the outermnemonicwas not being updated and resulted empty even when a custom one was provided.With this simple fix, the command returns to work properly.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes