Index supply by denom #8517

sahith-narahari · 2021-02-04T18:34:41Z

Description

closes: #7092

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

x/bank/keeper/keeper.go

…ex-supply

codecov · 2021-03-02T14:01:28Z

Codecov Report

Merging #8517 (7c55f94) into master (2864eb6) will increase coverage by 0.02%.
The diff coverage is 75.47%.

@@            Coverage Diff             @@
##           master    #8517      +/-   ##
==========================================
+ Coverage   61.40%   61.42%   +0.02%     
==========================================
  Files         674      671       -3     
  Lines       38397    38354      -43     
==========================================
- Hits        23577    23559      -18     
+ Misses      12336    12314      -22     
+ Partials     2484     2481       -3

Impacted Files	Coverage Δ
x/bank/types/codec.go	`50.00% <ø> (+8.82%)`	⬆️
x/staking/keeper/pool.go	`52.17% <0.00%> (ø)`
x/bank/types/genesis.go	`52.00% <50.00%> (ø)`
x/bank/keeper/keeper.go	`72.91% <71.05%> (-1.05%)`	⬇️
x/bank/keeper/genesis.go	`68.42% <100.00%> (ø)`
x/bank/keeper/grpc_query.go	`41.33% <100.00%> (ø)`
x/bank/keeper/invariants.go	`65.62% <100.00%> (ø)`
x/bank/keeper/querier.go	`74.13% <100.00%> (ø)`
x/bank/module.go	`55.81% <100.00%> (ø)`
x/feegrant/simulation/decoder.go	`0.00% <0.00%> (-100.00%)`	⬇️
... and 3 more

aaronc

LGTM as long as we paginate GetTotalSupply in a follow up

sahith-narahari · 2021-03-02T20:22:27Z

LGTM as long as we paginate GetTotalSupply in a follow up

Does it make sense to have seperate GetPaginatedTotalSupply as GetTotalSupply is being used across multiple places where the pagination is not necessary?

aaronc · 2021-03-02T20:59:35Z

LGTM as long as we paginate GetTotalSupply in a follow up

Does it make sense to have seperate GetPaginatedTotalSupply as GetTotalSupply is being used across multiple places where the pagination is not necessary?

IMHO anywhere GetTotalSupply is being used without pagination should be viewed as a problem. What if there are 10,000 or 1 million denoms in state? That might seem crazy today but at least in our use case we'll be creating LOTS of micro-currencies.

alessio · 2021-03-03T09:28:58Z

I agree with @aaronc. Please at the very least let's open a follow-up issue.

alessio · 2021-03-03T09:29:31Z

@sahith-narahari please add a CHANGELOG entry too

sahith-narahari · 2021-03-03T09:38:14Z

LGTM as long as we paginate GetTotalSupply in a follow up

Does it make sense to have seperate GetPaginatedTotalSupply as GetTotalSupply is being used across multiple places where the pagination is not necessary?

IMHO anywhere GetTotalSupply is being used without pagination should be viewed as a problem. What if there are 10,000 or 1 million denoms in state? That might seem crazy today but at least in our use case we'll be creating LOTS of micro-currencies.

Sure, I'll make a followup issue. Should we also extend the same to GetAllBalances which is more widely used across other modules without pagination

alessio · 2021-03-03T09:54:24Z

LGTM as long as we paginate GetTotalSupply in a follow up

Does it make sense to have seperate GetPaginatedTotalSupply as GetTotalSupply is being used across multiple places where the pagination is not necessary?

IMHO anywhere GetTotalSupply is being used without pagination should be viewed as a problem. What if there are 10,000 or 1 million denoms in state? That might seem crazy today but at least in our use case we'll be creating LOTS of micro-currencies.

Sure, I'll make a followup issue. Should we also extend the same to GetAllBalances which is more widely used across other modules without pagination

Yes, I think that makes sense too.

amaury1093 · 2021-03-03T10:06:48Z

Is a state migration needed for this? If yes, could you add one in x/bank/legacy/042?

sahith-narahari · 2021-03-03T10:13:27Z

Is a state migration needed for this? If yes, could you add one in x/bank/legacy/042?

Sure, I'll do it in the followup PR along with paginating supply.

aaronc · 2021-03-03T14:03:35Z

Is a state migration needed for this? If yes, could you add one in x/bank/legacy/042?

Yes it is. Could you add this to the tracking issue and reopen it @AmauryM ?

amaury1093 · 2021-03-03T14:24:00Z

#7092 (comment)

amaury1093 · 2021-03-04T10:18:25Z

proto/cosmos/bank/v1beta1/bank.proto

@@ -43,19 +43,6 @@ message Output {
      [(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins"];
 }

-// Supply represents a struct that passively keeps track of the total supply
-// amounts in the network.
-message Supply {


This is a proto-breaking change. I'm okay to remove it in the v1beta2 package but not here.

I'm adding it back in the migration PR, and adding a deprecated comment to it.

We can keep it in the proto files even though it's not used for now. Deprecated is the right step.

amaury1093 · 2021-03-04T10:30:29Z

x/feegrant/simulation/decoder_test.go

@@ -22,6 +22,7 @@ var (
 )

 func TestDecodeStore(t *testing.T) {
+	t.Skip()


Is there a reason this test was skipped?

@sahith-narahari

Oops sorry, this is unintended. Can you remove it in the store migration PR

temp commit

27a31a8

aaronc reviewed Feb 5, 2021

View reviewed changes

x/bank/keeper/keeper.go Show resolved Hide resolved

aaronc reviewed Feb 5, 2021

View reviewed changes

x/bank/keeper/keeper.go Outdated Show resolved Hide resolved

aaronc mentioned this pull request Feb 5, 2021

[Bank refactor]: finalize removal of setbalances from auth #8527

Merged

9 tasks

sahith-narahari added 12 commits February 8, 2021 19:44

remove supply

08a1db4

update tests

8d25a6d

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/ind…

2c6b5d0

…ex-supply

Merge branch 'master' into sahith/index-supply

2905994

revert proto script

aca7d2b

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/ind…

f53ac84

…ex-supply

fix lint

61cbf6a

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/ind…

8aeb7e8

…ex-supply

update tests

5dba0b7

remove decoder

64524da

fix lint

d9e346e

update set supply

a3559ce

Merge branch 'master' into sahith/index-supply

7c55f94

sahith-narahari marked this pull request as ready for review March 2, 2021 16:59

sahith-narahari requested review from alessio and alexanderbez as code owners March 2, 2021 16:59

jgimeno requested review from robert-zaremba, fdymylja, amaury1093, aaronc and fedekunze March 2, 2021 17:00

alessio requested review from jgimeno and gsora March 2, 2021 17:38

aaronc approved these changes Mar 2, 2021

View reviewed changes

alessio approved these changes Mar 3, 2021

View reviewed changes

Merge branch 'master' into sahith/index-supply

b43fce8

jgimeno approved these changes Mar 3, 2021

View reviewed changes

add changelog

78a3f3f

alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 3, 2021

mergify bot merged commit eb8aaf9 into master Mar 3, 2021

mergify bot deleted the sahith/index-supply branch March 3, 2021 09:58

sahith-narahari mentioned this pull request Mar 3, 2021

Paginate supply and balances methods #8761

Closed

6 tasks

amaury1093 mentioned this pull request Mar 3, 2021

Index supply by denom #7092

Closed

2 tasks

amaury1093 reviewed Mar 4, 2021

View reviewed changes

amaury1093 mentioned this pull request Mar 4, 2021

Supply by denom Migrations #8780

Merged

9 tasks

0xHansLee mentioned this pull request Jun 22, 2022

feat: upgrade cosmos-sdk v0.45.4 medibloc/panacea-core#356

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Index supply by denom #8517

Index supply by denom #8517

sahith-narahari commented Feb 4, 2021

codecov bot commented Mar 2, 2021 •

edited

Loading

aaronc left a comment

sahith-narahari commented Mar 2, 2021

aaronc commented Mar 2, 2021

alessio commented Mar 3, 2021

alessio commented Mar 3, 2021

sahith-narahari commented Mar 3, 2021

alessio commented Mar 3, 2021

amaury1093 commented Mar 3, 2021 •

edited

Loading

sahith-narahari commented Mar 3, 2021

aaronc commented Mar 3, 2021

amaury1093 commented Mar 3, 2021

amaury1093 Mar 4, 2021

aaronc Mar 4, 2021

amaury1093 Mar 4, 2021

jgimeno Mar 4, 2021

sahith-narahari Mar 4, 2021

Index supply by denom #8517

Index supply by denom #8517

Conversation

sahith-narahari commented Feb 4, 2021

Description

codecov bot commented Mar 2, 2021 • edited Loading

Codecov Report

aaronc left a comment

Choose a reason for hiding this comment

sahith-narahari commented Mar 2, 2021

aaronc commented Mar 2, 2021

alessio commented Mar 3, 2021

alessio commented Mar 3, 2021

sahith-narahari commented Mar 3, 2021

alessio commented Mar 3, 2021

amaury1093 commented Mar 3, 2021 • edited Loading

sahith-narahari commented Mar 3, 2021

aaronc commented Mar 3, 2021

amaury1093 commented Mar 3, 2021

amaury1093 Mar 4, 2021

Choose a reason for hiding this comment

aaronc Mar 4, 2021

Choose a reason for hiding this comment

amaury1093 Mar 4, 2021

Choose a reason for hiding this comment

jgimeno Mar 4, 2021

Choose a reason for hiding this comment

sahith-narahari Mar 4, 2021

Choose a reason for hiding this comment

codecov bot commented Mar 2, 2021 •

edited

Loading

amaury1093 commented Mar 3, 2021 •

edited

Loading