Capability Fixes #7918
Merged
Capability Fixes #7918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
requested review from
aaronc,
alessio and
alexanderbez
as code owners
AdityaSripal
requested review from
ebuchman,
fedekunze,
colin-axner and
cwgoes
Codecov Report
@@ Coverage Diff @@
## master #7918 +/- ##
=======================================
Coverage 54.15% 54.16%
=======================================
Files 612 612
Lines 38980 38998 +18
=======================================
+ Hits 21109 21122 +13
- Misses 15701 15703 +2
- Partials 2170 2173 +3 |
fedekunze
approved these changes
Nov 12, 2020
alexanderbez
approved these changes
Nov 12, 2020
fedekunze
added
A:automerge
colin-axner
reviewed
Nov 13, 2020
AdityaSripal
added
the
A:automerge
ebuchman
reviewed
Nov 16, 2020
| return nil, false | ||
| } | ||
|
|
||
| cap := sk.capMap[index] | ||
| if cap == nil { | ||
| // delete key from store to remove unnecessary mapping |
There was a problem hiding this comment.
Was there a reason this was expected to happen before?
There was a problem hiding this comment.
As far as we can tell, no. Maybe some prior bug which has since been fixed.
There was a problem hiding this comment.
No, afaik this should never happen. I think it used to just ignore the inconsistency and move on, now we panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7907
closes: #7909
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes