-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: proto #7893
docker: proto #7893
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7893 +/- ##
=======================================
Coverage 54.18% 54.18%
=======================================
Files 612 612
Lines 38958 38958
=======================================
Hits 21110 21110
Misses 15690 15690
Partials 2158 2158 |
this is blocked on docker hub permission issues |
Co-authored-by: Alessio Treglia <[email protected]>
@@ -361,6 +361,11 @@ proto-all: proto-tools proto-gen proto-lint proto-check-breaking proto-swagger-g | |||
proto-gen: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this target then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't remove it because some people may want to not use docker. I can remove it though. Dont have a preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i might still use this one.
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Description
closes: #7332
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes