Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: proto #7893

Merged
merged 9 commits into from
Nov 12, 2020
Merged

docker: proto #7893

merged 9 commits into from
Nov 12, 2020

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Nov 11, 2020

Description

  • migrate to solely using buf, no more need to install protoc.
  • install protoc-gen-gocosmos within the build script.
    • The install script says to run the command in the root, might as well just put it with the install.

closes: #7332


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@tac0turtle tac0turtle self-assigned this Nov 11, 2020
@tac0turtle tac0turtle added the T: Dev UX UX for SDK developers (i.e. how to call our code) label Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #7893 (2237274) into master (e9f1922) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7893   +/-   ##
=======================================
  Coverage   54.18%   54.18%           
=======================================
  Files         612      612           
  Lines       38958    38958           
=======================================
  Hits        21110    21110           
  Misses      15690    15690           
  Partials     2158     2158           

@tac0turtle
Copy link
Member Author

this is blocked on docker hub permission issues

@tac0turtle tac0turtle marked this pull request as ready for review November 11, 2020 18:02
Makefile Outdated Show resolved Hide resolved
@@ -361,6 +361,11 @@ proto-all: proto-tools proto-gen proto-lint proto-check-breaking proto-swagger-g
proto-gen:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this target then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remove it because some people may want to not use docker. I can remove it though. Dont have a preference.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i might still use this one.

scripts/protocgen.sh Outdated Show resolved Hide resolved
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 12, 2020
@mergify mergify bot merged commit 104a203 into master Nov 12, 2020
@mergify mergify bot deleted the 7332/docker_proto branch November 12, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make proto-tools script creates unbuildable proto files
4 participants