-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add new section "Running a Node" #7701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments and suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments, but otherwise lgtm!
Co-authored-by: Cory <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
… into am-7657-run-node
Co-authored-by: Cory <[email protected]>
… into am-7657-run-node
Codecov Report
@@ Coverage Diff @@
## master #7701 +/- ##
==========================================
+ Coverage 54.19% 54.21% +0.02%
==========================================
Files 610 609 -1
Lines 38872 38872
==========================================
+ Hits 21065 21076 +11
+ Misses 15650 15638 -12
- Partials 2157 2158 +1 |
Thanks a bunch @robert-zaremba @alessio @clevinson for this review, it was very helpful! I believe I addressed all comments, would appreciate another round of review. |
Description
ref: #7657
ref: #7403
rendered
interfaces/keyring.md
torun-node/keyring.md
, and update content.using-the-sdk/quickstart.md
torun-node/run-node.md
andrun-node/interact-node.md
, and update content.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes