-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetTx gRPC endpoint #7688
Add GetTx gRPC endpoint #7688
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7688 +/- ##
==========================================
+ Coverage 54.21% 54.31% +0.10%
==========================================
Files 611 610 -1
Lines 38654 38612 -42
==========================================
+ Hits 20956 20972 +16
+ Misses 15564 15503 -61
- Partials 2134 2137 +3 |
Co-authored-by: Cory <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
message GetTxResponse { | ||
// tx is the queried transaction. | ||
cosmos.tx.v1beta1.Tx tx = 1; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be including other TxResponse
items like height, data, logs, etc.?
* Add empty TxByHash * Fix search & replace * Renname to GetTx * Make getTx grpc work * Hash as string * Add todo comment * /tx * Make tests pass * Put into function * Add changelog * Fix lint * RegisterTxService in server * Remove comment * Update proto/cosmos/tx/v1beta1/service.proto Co-authored-by: Cory <[email protected]> * Create new protoCdc * Move tx service to x/auth * Small tweaks * Link gh issue * Fix lint * Update x/auth/tx/service.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Cory <[email protected]> Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: SaReN <[email protected]>
Description
ref: #7355
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes