Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetTx gRPC endpoint #7688

Merged
merged 25 commits into from
Oct 30, 2020
Merged

Add GetTx gRPC endpoint #7688

merged 25 commits into from
Oct 30, 2020

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Oct 27, 2020

Description

ref: #7355

  • test with gRPC
  • test with grpc-gateway

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #7688 into master will increase coverage by 0.10%.
The diff coverage is 62.74%.

@@            Coverage Diff             @@
##           master    #7688      +/-   ##
==========================================
+ Coverage   54.21%   54.31%   +0.10%     
==========================================
  Files         611      610       -1     
  Lines       38654    38612      -42     
==========================================
+ Hits        20956    20972      +16     
+ Misses      15564    15503      -61     
- Partials     2134     2137       +3     

@amaury1093 amaury1093 changed the title Add TxByHash gRPC endpoint Add GetTx gRPC endpoint Oct 27, 2020
types/tx/service_test.go Outdated Show resolved Hide resolved
types/tx/service.go Outdated Show resolved Hide resolved
@amaury1093 amaury1093 marked this pull request as ready for review October 27, 2020 17:55
baseapp/grpcrouter.go Outdated Show resolved Hide resolved
proto/cosmos/tx/v1beta1/service.proto Outdated Show resolved Hide resolved
proto/cosmos/tx/v1beta1/service.proto Show resolved Hide resolved
server/types/app.go Show resolved Hide resolved
types/tx/service.go Outdated Show resolved Hide resolved
types/tx/service.go Outdated Show resolved Hide resolved
types/tx/service.go Outdated Show resolved Hide resolved
types/tx/service.go Outdated Show resolved Hide resolved
baseapp/grpcrouter.go Outdated Show resolved Hide resolved
client/tx/tx.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/auth/tx/service.go Outdated Show resolved Hide resolved
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 30, 2020
@mergify mergify bot merged commit 1961935 into master Oct 30, 2020
@mergify mergify bot deleted the am-7355-grpc-txbyhash branch October 30, 2020 12:32
message GetTxResponse {
// tx is the queried transaction.
cosmos.tx.v1beta1.Tx tx = 1;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be including other TxResponse items like height, data, logs, etc.?

@clevinson clevinson mentioned this pull request Oct 31, 2020
9 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* Add empty TxByHash

* Fix search & replace

* Renname to GetTx

* Make getTx grpc work

* Hash as string

* Add todo comment

* /tx

* Make tests pass

* Put into function

* Add changelog

* Fix lint

* RegisterTxService in server

* Remove comment

* Update proto/cosmos/tx/v1beta1/service.proto

Co-authored-by: Cory <[email protected]>

* Create new protoCdc

* Move tx service to x/auth

* Small tweaks

* Link gh issue

* Fix lint

* Update x/auth/tx/service.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

Co-authored-by: Cory <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: SaReN <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants