-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fee payer to protobuf definition #7384
Merged
mergify
merged 8 commits into
cosmos:master
from
CosmWasm:ethanfrey/7341-add-fee-payer-to-tx
Sep 30, 2020
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
665e718
Add fee payer to protobuf definition
ethanfrey 28395d9
Compile new tx type
ethanfrey ee33f20
Use FeePayer from Tx, add it to required signers
ethanfrey 04f63d1
Add unit tests on proper handling of FeePayer field
ethanfrey c9b003e
Use string address for fee payer field
ethanfrey 2932b45
Update logic for string feePayer
ethanfrey cce336e
Merge branch 'master' into ethanfrey/7341-add-fee-payer-to-tx
ethanfrey 885b672
Merge branch 'master' into ethanfrey/7341-add-fee-payer-to-tx
ethanfrey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will we do here when we have fee grants working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think fee grants will be enough of a project that we do some more refactoring then.
My first idea was "Refactor this code and make changes to the various ante handlers.". However, on reflection, the current functionality is actually quite useful with no more and should not be removed. Maybe fee grants could add a separate field to specify a grant. eg.
payer
andgranter
unset is as now (paid from first signer)payer
set andgranter
unset is like my PR (paid from specified payer, who is added to signers)payer
set andgranter
set means the payer (who signed) will attempt to pay the fees via a fee grant from granter's account.payer
unset andgranter
set is either invalid or says the first signer attempts to pay from the granter's accountThis is just my first reflection. We could add this
granter
field by 0.40 if you wish, but I would make that a separate PR, and not worry about implementing that until the fee grant module (which may be 0.40.x if you add the field now, or maybe 0.41)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that could work. It does add the overhead of another field, but it does seem clearer and allow the additional third use case you've specified.