Fix "auto" Gas #7207

alexanderbez · 2020-08-31T14:30:53Z

Description

Update simulation query path
Fix gRPC error generation

closes: #7202

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

alexanderbez · 2020-08-31T14:31:25Z

Current error: proto: illegal wireType 7

codecov · 2020-08-31T14:35:42Z

Codecov Report

Merging #7207 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7207   +/-   ##
=======================================
  Coverage   54.98%   54.98%           
=======================================
  Files         562      562           
  Lines       38680    38680           
=======================================
  Hits        21270    21270           
  Misses      15663    15663           
  Partials     1747     1747

alexanderbez · 2020-08-31T14:42:35Z

I would like to get more input from @aaronc or @amaurymartiny before digging further down the rabbit hole.

I've added logs to simulateServer#Simulate to try and figure out what the issue is, but I'm not even seeing these logs, which leads me to believe that the error is somewhere upstream before it even calls the gRPC simulation service.

jackzampolin · 2020-08-31T16:04:59Z

Just dropping a note: this is blocking the relayer implementation now.

michaelfig · 2020-08-31T18:19:36Z

I get the following panic with 323abcd any advice?

Error: recovered: runtime error: invalid memory address or nil pointer dereference
stack:
goroutine 240 [running]:
runtime/debug.Stack(0x18, 0x1213f92a0, 0xc003b26b40)
        /usr/local/Cellar/go/1.14.2_1/libexec/src/runtime/debug/stack.go:24 +0x9d
github.com/cosmos/cosmos-sdk/baseapp.newDefaultRecoveryMiddleware.func1(0x12135ede0, 0x1227cd0b0, 0x0, 0xc003c8ae58)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/recovery.go:71 +0x26
github.com/cosmos/cosmos-sdk/baseapp.newRecoveryMiddleware.func1(0x12135ede0, 0x1227cd0b0, 0x0, 0x0, 0xc000d759e0)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/recovery.go:39 +0x42
github.com/cosmos/cosmos-sdk/baseapp.processRecovery(0x12135ede0, 0x1227cd0b0, 0xc000d759e0, 0x0, 0x0)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/recovery.go:28 +0x43
github.com/cosmos/cosmos-sdk/baseapp.processRecovery(0x12135ede0, 0x1227cd0b0, 0xc003b26b60, 0x121a942c0, 0xc003b05a00)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/recovery.go:33 +0x7e
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx.func1(0xc003c9c460, 0xc003c9c910, 0xc000f0c000, 0xc003c9e068, 0xc003c9e060, 0xc003c9e050)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/baseapp.go:527 +0x167
panic(0x12135ede0, 0x1227cd0b0)
        /usr/local/Cellar/go/1.14.2_1/libexec/src/runtime/panic.go:969 +0x166
github.com/cosmos/cosmos-sdk/x/auth/ante.SetUpContextDecorator.AnteHandle.func1(0x14c0fb948, 0xc0036d8770, 0xc003c9b510, 0xc003c9b720)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/ante/setup.go:59 +0x25b
panic(0x12135ede0, 0x1227cd0b0)
        /usr/local/Cellar/go/1.14.2_1/libexec/src/runtime/panic.go:969 +0x166
github.com/cosmos/cosmos-sdk/x/auth/tx.ModeInfoAndSigToSignatureData(0x0, 0x122823758, 0x0, 0x0, 0xc0036e6700, 0x72, 0x72, 0x121a79760)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/tx/sigs.go:59 +0x37
github.com/cosmos/cosmos-sdk/x/auth/tx.(*wrapper).GetSignaturesV2(0xc0036d8770, 0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/tx/builder.go:241 +0x136
github.com/cosmos/cosmos-sdk/x/auth/ante.SigGasConsumeDecorator.AnteHandle(0x121a79fa0, 0xc000f09d40, 0x12179d9b0, 0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/ante/sigverify.go:115 +0x127
github.com/cosmos/cosmos-sdk/types.ChainAnteDecorators.func1(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/types/handler.go:40 +0x124
github.com/cosmos/cosmos-sdk/x/auth/ante.DeductFeeDecorator.AnteHandle(0x121a79fa0, 0xc000f09d40, 0x107219800, 0xc000f0cf20, 0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/ante/fee.go:102 +0x23b
github.com/cosmos/cosmos-sdk/types.ChainAnteDecorators.func1(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/types/handler.go:40 +0x124
github.com/cosmos/cosmos-sdk/x/auth/ante.ValidateSigCountDecorator.AnteHandle(0x121a79fa0, 0xc000f09d40, 0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/ante/sigverify.go:313 +0x217
github.com/cosmos/cosmos-sdk/types.ChainAnteDecorators.func1(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/types/handler.go:40 +0x124
github.com/cosmos/cosmos-sdk/x/auth/ante.SetPubKeyDecorator.AnteHandle(0x121a79fa0, 0xc000f09d40, 0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/ante/sigverify.go:89 +0x1aa
github.com/cosmos/cosmos-sdk/types.ChainAnteDecorators.func1(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/types/handler.go:40 +0x124
github.com/cosmos/cosmos-sdk/x/auth/ante.ConsumeTxSizeGasDecorator.AnteHandle(0x121a79fa0, 0xc000f09d40, 0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/ante/basic.go:141 +0x2b3
github.com/cosmos/cosmos-sdk/types.ChainAnteDecorators.func1(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/types/handler.go:40 +0x124
github.com/cosmos/cosmos-sdk/x/auth/ante.ValidateMemoDecorator.AnteHandle(0x121a79fa0, 0xc000f09d40, 0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/ante/basic.go:70 +0x2b1
github.com/cosmos/cosmos-sdk/types.ChainAnteDecorators.func1(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/types/handler.go:40 +0x124
github.com/cosmos/cosmos-sdk/x/auth/ante.TxTimeoutHeightDecorator.AnteHandle(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/ante/basic.go:175 +0x280
github.com/cosmos/cosmos-sdk/types.ChainAnteDecorators.func1(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/types/handler.go:40 +0x124
github.com/cosmos/cosmos-sdk/x/auth/ante.ValidateBasicDecorator.AnteHandle(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/ante/basic.go:38 +0x14b
github.com/cosmos/cosmos-sdk/types.ChainAnteDecorators.func1(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/types/handler.go:40 +0x124
github.com/cosmos/cosmos-sdk/x/auth/ante.MempoolFeeDecorator.AnteHandle(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/ante/fee.go:58 +0x186
github.com/cosmos/cosmos-sdk/types.ChainAnteDecorators.func1(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/types/handler.go:40 +0x124
github.com/cosmos/cosmos-sdk/x/auth/ante.RejectExtensionOptionsDecorator.AnteHandle(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/ante/ext.go:35 +0xed
github.com/cosmos/cosmos-sdk/types.ChainAnteDecorators.func1(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/types/handler.go:40 +0x124
github.com/cosmos/cosmos-sdk/x/auth/ante.SetUpContextDecorator.AnteHandle(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/x/auth/ante/setup.go:64 +0x493
github.com/cosmos/cosmos-sdk/types.ChainAnteDecorators.func1(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b05a40, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/types/handler.go:40 +0x124
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx(0xc000f0c000, 0x121a5ae02, 0xc0036e6700, 0x72, 0x72, 0x121a5aea0, 0xc0036d8770, 0x0, 0x0, 0x0, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/baseapp.go:571 +0x808
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).Simulate(...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/helpers.go:14
github.com/cosmos/cosmos-sdk/client/grpc/simulate.simulateServer.Simulate(0xc0006b62b0, 0x121a7cbe0, 0xc000ef8740, 0x121a5d4a0, 0x122823758, 0x121a793e0, 0xc003b1b920, 0xc0035cebe0, 0x0, 0x0, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/client/grpc/simulate/simulate.go:52 +0x1e7
github.com/cosmos/cosmos-sdk/client/grpc/simulate._SimulateService_Simulate_Handler(0x12143ee40, 0xc000642cf0, 0x121a793e0, 0xc003b1b920, 0xc0036eb400, 0x0, 0x121a793e0, 0xc003b1b920, 0x6, 0x0)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/client/grpc/simulate/simulate.pb.go:228 +0x217
github.com/cosmos/cosmos-sdk/baseapp.(*GRPCQueryRouter).RegisterService.func1(0x121a79360, 0xc0000440d0, 0x121a942c0, 0xc003b059c0, 0xb, 0x0, 0xc0010f8560, 0x6, 0x449, 0x236298, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/grpcrouter.go:68 +0x1d9
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).handleQueryGRPC(0xc000f0c000, 0xc000642d20, 0xc003b201e0, 0x74, 0xf0, 0xc0036fd840, 0x36, 0x0, 0x0, 0x0, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/abci.go:367 +0x11e
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).Query(0xc000f0c000, 0xc003b201e0, 0x74, 0xf0, 0xc0036fd840, 0x36, 0x0, 0x0, 0x0, 0x0, ...)
        /Users/michael/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/abci.go:335 +0x801
github.com/tendermint/tendermint/abci/client.(*localClient).QuerySync(0xc000d164e0, 0xc003b201e0, 0x74, 0xf0, 0xc0036fd840, 0x36, 0x0, 0x0, 0x0, 0x0, ...)
        /Users/michael/go/pkg/mod/github.com/tendermint/[email protected]/abci/client/local_client.go:250 +0x10e
github.com/tendermint/tendermint/proxy.(*appConnQuery).QuerySync(0xc0006b7710, 0xc003b201e0, 0x74, 0xf0, 0xc0036fd840, 0x36, 0x0, 0x0, 0x203000, 0x1212bac60, ...)
        /Users/michael/go/pkg/mod/github.com/tendermint/[email protected]/proxy/app_conn.go:159 +0x68
github.com/tendermint/tendermint/rpc/core.ABCIQuery(0xc003b09660, 0xc0036fd840, 0x36, 0xc003b201e0, 0x74, 0xf0, 0x0, 0x0, 0x0, 0x0, ...)
        /Users/michael/go/pkg/mod/github.com/tendermint/[email protected]/rpc/core/abci.go:20 +0x10a
reflect.Value.call(0x12137d6a0, 0x12179f470, 0x13, 0x1215683eb, 0x4, 0xc0036cee00, 0x5, 0x5, 0x5, 0x18, ...)
        /usr/local/Cellar/go/1.14.2_1/libexec/src/reflect/value.go:460 +0x8ab
reflect.Value.Call(0x12137d6a0, 0x12179f470, 0x13, 0xc0036cee00, 0x5, 0x5, 0x4, 0x4, 0x0)
        /usr/local/Cellar/go/1.14.2_1/libexec/src/reflect/value.go:321 +0xb4
github.com/tendermint/tendermint/rpc/jsonrpc/server.makeJSONRPCHandler.func1(0x121a71360, 0xc003b09620, 0xc003b18300)
        /Users/michael/go/pkg/mod/github.com/tendermint/[email protected]/rpc/jsonrpc/server/http_json_handler.go:102 +0x9d5
github.com/tendermint/tendermint/rpc/jsonrpc/server.handleInvalidJSONRPCPaths.func1(0x121a71360, 0xc003b09620, 0xc003b18300)
        /Users/michael/go/pkg/mod/github.com/tendermint/[email protected]/rpc/jsonrpc/server/http_json_handler.go:126 +0x9c
net/http.HandlerFunc.ServeHTTP(0xc0001f3040, 0x121a71360, 0xc003b09620, 0xc003b18300)
        /usr/local/Cellar/go/1.14.2_1/libexec/src/net/http/server.go:2012 +0x44
net/http.(*ServeMux).ServeHTTP(0xc000123dc0, 0x121a71360, 0xc003b09620, 0xc003b18300)
        /usr/local/Cellar/go/1.14.2_1/libexec/src/net/http/server.go:2387 +0x1a5
github.com/tendermint/tendermint/rpc/jsonrpc/server.maxBytesHandler.ServeHTTP(0x121a3f460, 0xc000123dc0, 0xf4240, 0x121a71360, 0xc003b09620, 0xc003b18300)
        /Users/michael/go/pkg/mod/github.com/tendermint/[email protected]/rpc/jsonrpc/server/http_server.go:234 +0xcf
github.com/tendermint/tendermint/rpc/jsonrpc/server.RecoverAndLogHandler.func1(0x121a71f20, 0xc0010107e0, 0xc003b18300)
        /Users/michael/go/pkg/mod/github.com/tendermint/[email protected]/rpc/jsonrpc/server/http_server.go:207 +0x38e
net/http.HandlerFunc.ServeHTTP(0xc00110a000, 0x121a71f20, 0xc0010107e0, 0xc003b18300)
        /usr/local/Cellar/go/1.14.2_1/libexec/src/net/http/server.go:2012 +0x44
net/http.serverHandler.ServeHTTP(0xc0000e4380, 0x121a71f20, 0xc0010107e0, 0xc003b18300)
        /usr/local/Cellar/go/1.14.2_1/libexec/src/net/http/server.go:2807 +0xa3
net/http.(*conn).serve(0xc003ada460, 0x121a79320, 0xc003aa7c80)
        /usr/local/Cellar/go/1.14.2_1/libexec/src/net/http/server.go:1895 +0x86c
created by net/http.(*Server).Serve
        /usr/local/Cellar/go/1.14.2_1/libexec/src/net/http/server.go:2933 +0x35c
: panic: invalid request

jackzampolin · 2020-08-31T18:21:23Z

@michaelfig still debugging.

client/tx/tx.go

jackzampolin · 2020-08-31T18:57:04Z

Thanks to help from @amaurymartiny I've got this working. Marking this R4R.

alexanderbez · 2020-08-31T19:29:17Z

ACK although it's my PR so I can't approve.

alessio · 2020-08-31T20:26:01Z

I've approved it though tests need to be fixed

alexanderbez · 2020-09-01T13:19:54Z

@jackzampolin can you please look into TestCalculateGas?

jackzampolin · 2020-09-01T17:05:51Z

Working on it today @alexanderbez

…into bez/7202-fix-auto-gas

alexanderbez · 2020-09-01T21:07:02Z

Rebased latest master, but test still fails.

amaury1093

lgtm post-merge.

init commit

4f92b95

alexanderbez assigned alexanderbez and amaury1093 Aug 31, 2020

alexanderbez assigned aaronc, amaury1093 and alexanderbez and unassigned amaury1093 and alexanderbez Aug 31, 2020

jackzampolin added 4 commits August 31, 2020 09:36

Merge branch 'master' into bez/7202-fix-auto-gas

3348e34

Add simulation request

97f7d76

Merge branch 'master' into bez/7202-fix-auto-gas

323abcd

Push progress

abef200

amaury1093 reviewed Aug 31, 2020

View reviewed changes

client/tx/tx.go Outdated Show resolved Hide resolved

jackzampolin added 2 commits August 31, 2020 11:31

revert CalculateGas changes

1eaf3e2

Fix simulation response unmarshal

d5bbb72

jackzampolin marked this pull request as ready for review August 31, 2020 18:57

jackzampolin requested review from aaronc and alessio as code owners August 31, 2020 18:57

alexanderbez requested review from amaury1093, fedekunze, anilcse and blushi August 31, 2020 19:29

alexanderbez added A:automerge Automatically merge PR once all prerequisites pass. C:Simulations labels Aug 31, 2020

alessio approved these changes Aug 31, 2020

View reviewed changes

Merge branch 'master' into bez/7202-fix-auto-gas

92c1b01

Merge branch 'master' into bez/7202-fix-auto-gas

87f8eef

anilcse added 3 commits September 1, 2020 23:24

Fix tests

86bf2f8

Merge branch 'master' into bez/7202-fix-auto-gas

c1fc247

Merge branch 'bez/7202-fix-auto-gas' of github.com:cosmos/cosmos-sdk …

fed4a7b

…into bez/7202-fix-auto-gas

anilcse requested a review from jackzampolin September 1, 2020 18:00

anilcse and others added 4 commits September 1, 2020 23:46

Fix import

637965a

Fix tests

59d1558

refactor

c02b7f3

updates

4dc0f5d

fix simulation response unmarshalling

4169884

jackzampolin approved these changes Sep 1, 2020

View reviewed changes

mergify bot merged commit b043797 into master Sep 1, 2020

mergify bot deleted the bez/7202-fix-auto-gas branch September 1, 2020 22:44

amaury1093 reviewed Sep 2, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix "auto" Gas #7207

Fix "auto" Gas #7207

alexanderbez commented Aug 31, 2020 •

edited

Loading

alexanderbez commented Aug 31, 2020

codecov bot commented Aug 31, 2020 •

edited

Loading

alexanderbez commented Aug 31, 2020 •

edited

Loading

jackzampolin commented Aug 31, 2020

michaelfig commented Aug 31, 2020

jackzampolin commented Aug 31, 2020

jackzampolin commented Aug 31, 2020

alexanderbez commented Aug 31, 2020

alessio commented Aug 31, 2020 •

edited

Loading

alexanderbez commented Sep 1, 2020

jackzampolin commented Sep 1, 2020

alexanderbez commented Sep 1, 2020

amaury1093 left a comment

Fix "auto" Gas #7207

Fix "auto" Gas #7207

Conversation

alexanderbez commented Aug 31, 2020 • edited Loading

Description

alexanderbez commented Aug 31, 2020

codecov bot commented Aug 31, 2020 • edited Loading

Codecov Report

alexanderbez commented Aug 31, 2020 • edited Loading

jackzampolin commented Aug 31, 2020

michaelfig commented Aug 31, 2020

jackzampolin commented Aug 31, 2020

jackzampolin commented Aug 31, 2020

alexanderbez commented Aug 31, 2020

alessio commented Aug 31, 2020 • edited Loading

alexanderbez commented Sep 1, 2020

jackzampolin commented Sep 1, 2020

alexanderbez commented Sep 1, 2020

amaury1093 left a comment

Choose a reason for hiding this comment

alexanderbez commented Aug 31, 2020 •

edited

Loading

codecov bot commented Aug 31, 2020 •

edited

Loading

alexanderbez commented Aug 31, 2020 •

edited

Loading

alessio commented Aug 31, 2020 •

edited

Loading