-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert x/auth query CLI commands to use gRPC query client #6643
Convert x/auth query CLI commands to use gRPC query client #6643
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6643 +/- ##
==========================================
+ Coverage 55.60% 57.73% +2.13%
==========================================
Files 457 498 +41
Lines 27440 29797 +2357
==========================================
+ Hits 15257 17204 +1947
- Misses 11083 11350 +267
- Partials 1100 1243 +143 |
@@ -24,7 +25,7 @@ const ( | |||
) | |||
|
|||
// GetQueryCmd returns the transaction commands for this module | |||
func GetQueryCmd(cdc *codec.Codec) *cobra.Command { | |||
func GetQueryCmd(clientCtx client.Context) *cobra.Command { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an FYI, this will all be undone once #6573 is merged. I'm not sure about the order of preference here, but just keep that in mind.
Essentially, command constructors will take no arguments anymore (at least not client.Context
). They will instead use a clientCtx := client.GetClientContextFromCmd(cmd)
call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we can wait until #6573 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexanderbez Just to get this right: assuming we remove the client.Context
arg here and use clientCtx := client.GetClientContextFromCmd(cmd)
, we can still merge this PR before #6573, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If tests pass, yes 👍
Thanks @akhilkumarpilli, Closing this in favour of #6809 |
Description
ref: #5921
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes