-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/distribution: gRPC query service #6600
Conversation
…21-grpc-x-distribution
…21-grpc-x-distribution
…cosmos-sdk into atheesh/5921-grpc-x-distribution
Codecov Report
@@ Coverage Diff @@
## master #6600 +/- ##
==========================================
+ Coverage 55.38% 58.47% +3.09%
==========================================
Files 341 509 +168
Lines 19497 30861 +11364
==========================================
+ Hits 10799 18047 +7248
- Misses 7932 11472 +3540
- Partials 766 1342 +576 |
…21-grpc-x-distribution
…21-grpc-x-distribution
…21-grpc-x-distribution
…21-grpc-x-distribution
…21-grpc-x-distribution
…21-grpc-x-distribution
…21-grpc-x-distribution
…21-grpc-x-distribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Just one small question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
ref: #5921
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes