Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sdk.Msg implement proto.Message #6327

Merged
merged 10 commits into from
Jun 3, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleaning up
aaronc committed Jun 2, 2020
commit 27ae695f7afad27b129604f96c379c96a2b60bb3
16 changes: 8 additions & 8 deletions baseapp/baseapp_test.go
Original file line number Diff line number Diff line change
@@ -594,10 +594,10 @@ type msgCounter struct {
FailOnHandler bool
}

// Implements proto.Message
func (msg msgCounter) Reset() { panic("implement me") }
func (msg msgCounter) String() string { panic("implement me") }
func (msg msgCounter) ProtoMessage() { panic("implement me") }
// dummy implementation of proto.Message
func (msg msgCounter) Reset() {}
func (msg msgCounter) String() string { return "TODO" }
func (msg msgCounter) ProtoMessage() {}

// Implements Msg
func (msg msgCounter) Route() string { return routeMsgCounter }
@@ -639,10 +639,10 @@ type msgCounter2 struct {
Counter int64
}

// Implements proto.Message
func (msg msgCounter2) Reset() { panic("implement me") }
func (msg msgCounter2) String() string { panic("implement me") }
func (msg msgCounter2) ProtoMessage() { panic("implement me") }
// dummy implementation of proto.Message
func (msg msgCounter2) Reset() {}
func (msg msgCounter2) String() string { return "TODO" }
func (msg msgCounter2) ProtoMessage() {}

// Implements Msg
func (msg msgCounter2) Route() string { return routeMsgCounter2 }
15 changes: 4 additions & 11 deletions server/mock/tx.go
Original file line number Diff line number Diff line change
@@ -16,17 +16,10 @@ type kvstoreTx struct {
bytes []byte
}

func (tx kvstoreTx) Reset() {
panic("implement me")
}

func (tx kvstoreTx) String() string {
panic("implement me")
}

func (tx kvstoreTx) ProtoMessage() {
panic("implement me")
}
// dummy implementation of proto.Message
func (msg kvstoreTx) Reset() {}
func (msg kvstoreTx) String() string { return "TODO" }
func (msg kvstoreTx) ProtoMessage() {}

var _ sdk.Tx = kvstoreTx{}
var _ sdk.Msg = kvstoreTx{}
8 changes: 4 additions & 4 deletions types/tx_msg.go
Original file line number Diff line number Diff line change
@@ -74,10 +74,10 @@ type TestMsg struct {
signers []AccAddress
}

// implements proto.Message
func (msg *TestMsg) Reset() { panic("implement me") }
func (msg *TestMsg) String() string { panic("implement me") }
func (msg *TestMsg) ProtoMessage() { panic("implement me") }
// dummy implementation of proto.Message
func (msg *TestMsg) Reset() {}
func (msg *TestMsg) String() string { return "TODO" }
func (msg *TestMsg) ProtoMessage() {}

func NewTestMsg(addrs ...AccAddress) *TestMsg {
return &TestMsg{
24 changes: 12 additions & 12 deletions x/ibc/07-tendermint/types/msgs.go
Original file line number Diff line number Diff line change
@@ -39,10 +39,10 @@ type MsgCreateClient struct {
Signer sdk.AccAddress `json:"address" yaml:"address"`
}

// implements proto.Message by panicking
func (msg MsgCreateClient) Reset() { panic("implement me") }
func (msg MsgCreateClient) String() string { panic("implement me") }
func (msg MsgCreateClient) ProtoMessage() { panic("implement me") }
// dummy implementation of proto.Message
func (msg MsgCreateClient) Reset() {}
func (msg MsgCreateClient) String() string { return "TODO" }
func (msg MsgCreateClient) ProtoMessage() {}

// NewMsgCreateClient creates a new MsgCreateClient instance
func NewMsgCreateClient(
@@ -134,10 +134,10 @@ type MsgUpdateClient struct {
Signer sdk.AccAddress `json:"address" yaml:"address"`
}

// implements proto.Message by panicking
func (msg MsgUpdateClient) Reset() { panic("implement me") }
func (msg MsgUpdateClient) String() string { panic("implement me") }
func (msg MsgUpdateClient) ProtoMessage() { panic("implement me") }
// dummy implementation of proto.Message
func (msg MsgUpdateClient) Reset() {}
func (msg MsgUpdateClient) String() string { return "TODO" }
func (msg MsgUpdateClient) ProtoMessage() {}

// NewMsgUpdateClient creates a new MsgUpdateClient instance
func NewMsgUpdateClient(id string, header Header, signer sdk.AccAddress) MsgUpdateClient {
@@ -193,10 +193,10 @@ type MsgSubmitClientMisbehaviour struct {
Submitter sdk.AccAddress `json:"submitter" yaml:"submitter"`
}

// implements proto.Message by panicking
func (msg MsgSubmitClientMisbehaviour) Reset() { panic("implement me") }
func (msg MsgSubmitClientMisbehaviour) String() string { panic("implement me") }
func (msg MsgSubmitClientMisbehaviour) ProtoMessage() { panic("implement me") }
// dummy implementation of proto.Message
func (msg MsgSubmitClientMisbehaviour) Reset() {}
func (msg MsgSubmitClientMisbehaviour) String() string { return "TODO" }
func (msg MsgSubmitClientMisbehaviour) ProtoMessage() {}

// NewMsgSubmitClientMisbehaviour creates a new MsgSubmitClientMisbehaviour
// instance.