Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baseapp: track events emitted from AnteHandler #6187

Merged
merged 14 commits into from
May 11, 2020
Merged

baseapp: track events emitted from AnteHandler #6187

merged 14 commits into from
May 11, 2020

Conversation

fedekunze
Copy link
Collaborator

Description

closes: #6186

@auto-comment
Copy link

auto-comment bot commented May 11, 2020 •
edited by fedekunze
Loading

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

alexanderbez
alexanderbez reviewed May 11, 2020
View reviewed changes
@fedekunze fedekunze marked this pull request as ready for review May 11, 2020 19:24
jackzampolin
jackzampolin reviewed May 11, 2020
View reviewed changes
jackzampolin
jackzampolin approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK

cwgoes
cwgoes approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze requested a review from alexanderbez May 11, 2020 19:39
@codecov
Copy link

codecov bot commented May 11, 2020 •
edited
Loading

Codecov Report

Merging #6187 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6187   +/-   ##
=======================================
  Coverage   54.82%   54.83%           
=======================================
  Files         443      443           
  Lines       26745    26749    +4     
=======================================
+ Hits        14664    14668    +4     
  Misses      11040    11040           
  Partials     1041     1041

alexanderbez
alexanderbez suggested changes May 11, 2020
View reviewed changes
alexanderbez
alexanderbez reviewed May 11, 2020
View reviewed changes
@fedekunze fedekunze requested a review from alexanderbez May 11, 2020 21:00
alexanderbez
alexanderbez approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🌮

@fedekunze fedekunze merged commit 80be503 into master May 11, 2020
@fedekunze fedekunze deleted the fedekunze/6186-ante-events branch May 11, 2020 22:23
@zmanian zmanian mentioned this pull request May 29, 2020
Closed
4 tasks
leeyikjiun pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 14, 2020
@fedekunze @leeyikjiun
baseapp: track events emitted from AnteHandler (cosmos#6187)
6e3ca6b 
* baseapp: append AnteHandler events to tx result

* changelog

* baseapp tests

* fix test

* update changelog

* update log

* move event out from conditional

* minor update

* fix panic

* add switch case

* remove result on error

* change conditional

* check for event len

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@cwgoes cwgoes cwgoes approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@clevinson clevinson Awaiting requested review from clevinson

@hschoenburg hschoenburg Awaiting requested review from hschoenburg

@jgimeno jgimeno Awaiting requested review from jgimeno

@nylira nylira Awaiting requested review from nylira

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@zmanian zmanian Awaiting requested review from zmanian

Assignees
No one assigned
Labels
C:baseapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track Events Emitted from the AnteHandler
5 participants
@fedekunze @zmanian @alexanderbez @jackzampolin @cwgoes