Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch auth register cdc #5892

Merged
merged 12 commits into from
Mar 30, 2020
Merged

patch auth register cdc #5892

merged 12 commits into from
Mar 30, 2020

Conversation

fedekunze
Copy link
Collaborator

Closes: Chainsafe/ethermint#235

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze marked this pull request as ready for review March 30, 2020 15:25
@fedekunze fedekunze added the R4R label Mar 30, 2020
@fedekunze fedekunze mentioned this pull request Mar 30, 2020
Closed
@fedekunze fedekunze requested a review from okwme March 30, 2020 16:11
alexanderbez
alexanderbez suggested changes Mar 30, 2020
View reviewed changes
x/auth/types/codec.go Outdated Show resolved Hide resolved
@fedekunze fedekunze requested a review from alexanderbez March 30, 2020 17:11
alexanderbez
alexanderbez approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 30, 2020
@codecov
Copy link

codecov bot commented Mar 30, 2020 •
edited
Loading

Codecov Report

Merging #5892 into master will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #5892      +/-   ##
==========================================
- Coverage   56.82%   56.80%   -0.02%     
==========================================
  Files         342      342              
  Lines       20044    20046       +2     
==========================================
- Hits        11389    11388       -1     
- Misses       7805     7808       +3     
  Partials      850      850

@fedekunze fedekunze requested a review from jgimeno March 30, 2020 22:04
@mergify mergify bot merged commit 6a6fd1c into master Mar 30, 2020
@mergify mergify bot deleted the fedekunze/patch-auth-register-cdc branch March 30, 2020 22:09
@alexanderbez alexanderbez mentioned this pull request Apr 16, 2020
Closed
6 tasks
@Itchibon777 Itchibon777 mentioned this pull request Oct 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@jgimeno jgimeno jgimeno approved these changes

@alessio alessio Awaiting requested review from alessio

@hschoenburg hschoenburg Awaiting requested review from hschoenburg

@nylira nylira Awaiting requested review from nylira

@okwme okwme Awaiting requested review from okwme

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pubkey registration issue
3 participants
@fedekunze @jgimeno @alexanderbez