Migrate x/feegrant to proto #5782

sahith-narahari · 2020-03-10T19:32:00Z

Closes: #XXX

Description

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

lgtm-com · 2020-03-10T19:43:01Z

This pull request introduces 2 alerts when merging 60e328b into 8eddbb7 - view on LGTM.com

new alerts:

2 for Useless assignment to field

lgtm-com · 2020-03-11T10:18:05Z

This pull request introduces 2 alerts when merging 8a65766 into 8eddbb7 - view on LGTM.com

new alerts:

2 for Useless assignment to field

lgtm-com · 2020-03-11T12:53:06Z

This pull request introduces 2 alerts when merging 26e470b into 8eddbb7 - view on LGTM.com

new alerts:

2 for Useless assignment to field

lgtm-com · 2020-03-12T10:57:12Z

This pull request introduces 2 alerts when merging 1f676a8 into 8eddbb7 - view on LGTM.com

new alerts:

2 for Useless assignment to field

lgtm-com · 2020-03-17T21:55:04Z

This pull request introduces 2 alerts when merging 59eef6c into 8eddbb7 - view on LGTM.com

new alerts:

2 for Useless assignment to field

…smos-sdk into sahith/fee-auth-proto

lgtm-com · 2020-03-18T15:56:00Z

This pull request introduces 2 alerts when merging 47dc3bc into 8eddbb7 - view on LGTM.com

new alerts:

2 for Useless assignment to field

lgtm-com · 2020-03-23T13:42:18Z

This pull request introduces 2 alerts when merging 93c2418 into 8eddbb7 - view on LGTM.com

new alerts:

2 for Useless assignment to field

lgtm-com · 2020-03-24T14:10:16Z

This pull request introduces 2 alerts when merging 2fc60d9 into 8eddbb7 - view on LGTM.com

new alerts:

2 for Useless assignment to field

x/feegrant/types/types.proto

anilcse

Added a few comments

x/feegrant/handler.go

x/feegrant/keeper/keeper.go

x/feegrant/keeper/keeper_test.go

x/feegrant/keeper/querier.go

x/feegrant/types/codec.go

x/feegrant/types/msgs.go

anilcse

lgtm

x/feegrant/keeper/keeper.go

x/feegrant/exported/external.go

x/feegrant/types/expiration.go

x/feegrant/types/msgs.go

x/feegrant/types/types.proto

x/feegrant/types/grant.go

x/feegrant/types/msgs.go

x/feegrant/keeper/keeper.go

sahith-narahari · 2020-04-06T18:44:38Z

@alexanderbez addressed the recommended changes

alexanderbez

utACK 👍

* Add docs * Add BasicFeeAllowance implementation * Add expiration structs and complete basic fee * Add delegation messages, add validation logic * Add keeper and helper structs * Add alias and handler to top level * Add delegation module * Add basic querier * Add types tests * Add types tests * More internal test coverage * Solid internal test coverage * Expose Querier to top level module * Add FeeAccount to auth/types, like StdTx, SignDoc * Fix all tests in x/auth * All tests pass * Appease the Golang Linter * Add fee-account command line flag * Start on DelegatedDeductFeeDecorator * Cleanup the Decorator * Wire up delegation module in simapp * add basic test for decorator (no delegation) * Table tests for deduct fees * Table tests over all conditions of delegated fee decorator * Build full ante handler stack and test it * Start genesis * Implement Genesis * Rename package delegation to subkeys * Clarify antes test cases, handle empty account w/o fees * Allow paying delegated fees with no account * Pull mempool into delegated ante, for control on StdFee * Use custom DelegatedTx, DelegatedFee for subkeys * Revert all changes to x/auth.StdTx * Appease scopelint * Register DelegatedTx with codec * Address PR comments * Remove unnecessary DelegatedMempoolFeeDecorator * Cleaned up errors in querier * Clean up message sign bytes * Minor PR comments * Replace GetAllFees... with Iterator variants * PrepareForExport adjusts grant expiration height * Panic on de/serialization error in keeper * Move custom ante handler chain to tests, update docs * More cleanup * More doc cleanup * Renamed subkeys module to fee_grant * Rename subkeys/delegation to fee grant in all strings * Modify Msg and Keeper methods to use Grant not Delegate * Add PeriodicFeeAllowance * Update aliases * Cover all accept cases for PeriodicFeeAllowance * Et tu scopelint? * Update docs as requested * Remove error return from GetFeeGrant * Code cleanup as requested by PR * Updated all errors to use new sdk/errors package * Use test suite for keeper tests * Clean up alias.go file * Define expected interfaces in exported, rather than importing from account * Remove dependency on auth/ante * Improve godoc, Logger * Cleaned up ExpiresAt * Improve error reporting with UseGrantedFee * Enforce period limit subset of basic limit * Add events * Rename fee_grant to feegrant * Ensure KeeperTestSuite actually runs * Move types/tx to types * Update alias file, include ante * I do need nolint in alias.go * Properly emit events in the handler. Use cosmos-sdk in amino types * Update godoc * Linting... * Update errors * Update pkg doc and fix ante-handler order * Merge PR #5782: Migrate x/feegrant to proto * fix errors * proto changes * proto changes * fix errors * fix errors * genesis state changed to proto * fix keeper tests * fix test * fixed tests * fix tests * updated expected keepers * updated ante tests * lint * deleted alias.go * tx updated to proto tx * remove explicit signmode * tests * Added `cli/query.go` * Added tx.go in cli * updated `module.go` * resolve errors in tx.go * Add fee payer gentx func * updated tx * fixed error * WIP: cli tests * fix query error * fix tests * Unused types and funcs * fix tests * rename helper func to create tx * remove unused * update tx cfg * fix cli tests * added simulations * Add `decoder.go` * fix build fail * added init genesis code * update tx.go * fixed LGTM alert * modified cli * remove gogoproto extensions * change acc address type to string * lint * fix simulations * Add gen simulations * remove legacy querier * remove legacy code * add grpc queries tests * fix simulations * update module.go * lint * register feegrant NewSimulationManager * fix sims * fix sims * add genesis test * add periodic grant * updated cmd * changed times * updated flags * removed days as period clock * added condition for period and exp * add periodic fee cli tests * udpated tests * fix lint * fix tests * fix sims * renaming to `fee_grant` * review changes * fix test * add condition for duplicate grants * fix tests * add `genTxWithFeeGranter` in tests * fix simulation * one of changes & test fixes * fix test * fix lint * changed package name `feegrant` to `fee_grant` * review comments * review changes * review change * review changes * added fee-account in flags * address review changes * read fee granter from cli * updated create account with mnemonic * Address review comments * move `simapp/ante` file to `feegrant/ante` * update keeper logic to create account * update docs * fix tests * update `serviceMsgClientConn` from `msgservice` * review changes * add test case for using more fees than allowed * eliminate panic checks from keeper * fix lint * change store keys string to bytes * fix tests * review changes * review changes * udpate docs * make spend limit optional * fix tests * fix tests * review changes * add norace tag * proto-docs * add docs Co-authored-by: Ethan Frey <[email protected]> Co-authored-by: Alexander Bezobchuk <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: SaReN <[email protected]> Co-authored-by: aleem1413 <[email protected]> Co-authored-by: MD Aleem <[email protected]> Co-authored-by: Anil Kumar Kammari <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Add docs * Add BasicFeeAllowance implementation * Add expiration structs and complete basic fee * Add delegation messages, add validation logic * Add keeper and helper structs * Add alias and handler to top level * Add delegation module * Add basic querier * Add types tests * Add types tests * More internal test coverage * Solid internal test coverage * Expose Querier to top level module * Add FeeAccount to auth/types, like StdTx, SignDoc * Fix all tests in x/auth * All tests pass * Appease the Golang Linter * Add fee-account command line flag * Start on DelegatedDeductFeeDecorator * Cleanup the Decorator * Wire up delegation module in simapp * add basic test for decorator (no delegation) * Table tests for deduct fees * Table tests over all conditions of delegated fee decorator * Build full ante handler stack and test it * Start genesis * Implement Genesis * Rename package delegation to subkeys * Clarify antes test cases, handle empty account w/o fees * Allow paying delegated fees with no account * Pull mempool into delegated ante, for control on StdFee * Use custom DelegatedTx, DelegatedFee for subkeys * Revert all changes to x/auth.StdTx * Appease scopelint * Register DelegatedTx with codec * Address PR comments * Remove unnecessary DelegatedMempoolFeeDecorator * Cleaned up errors in querier * Clean up message sign bytes * Minor PR comments * Replace GetAllFees... with Iterator variants * PrepareForExport adjusts grant expiration height * Panic on de/serialization error in keeper * Move custom ante handler chain to tests, update docs * More cleanup * More doc cleanup * Renamed subkeys module to fee_grant * Rename subkeys/delegation to fee grant in all strings * Modify Msg and Keeper methods to use Grant not Delegate * Add PeriodicFeeAllowance * Update aliases * Cover all accept cases for PeriodicFeeAllowance * Et tu scopelint? * Update docs as requested * Remove error return from GetFeeGrant * Code cleanup as requested by PR * Updated all errors to use new sdk/errors package * Use test suite for keeper tests * Clean up alias.go file * Define expected interfaces in exported, rather than importing from account * Remove dependency on auth/ante * Improve godoc, Logger * Cleaned up ExpiresAt * Improve error reporting with UseGrantedFee * Enforce period limit subset of basic limit * Add events * Rename fee_grant to feegrant * Ensure KeeperTestSuite actually runs * Move types/tx to types * Update alias file, include ante * I do need nolint in alias.go * Properly emit events in the handler. Use cosmos-sdk in amino types * Update godoc * Linting... * Update errors * Update pkg doc and fix ante-handler order * Merge PR cosmos#5782: Migrate x/feegrant to proto * fix errors * proto changes * proto changes * fix errors * fix errors * genesis state changed to proto * fix keeper tests * fix test * fixed tests * fix tests * updated expected keepers * updated ante tests * lint * deleted alias.go * tx updated to proto tx * remove explicit signmode * tests * Added `cli/query.go` * Added tx.go in cli * updated `module.go` * resolve errors in tx.go * Add fee payer gentx func * updated tx * fixed error * WIP: cli tests * fix query error * fix tests * Unused types and funcs * fix tests * rename helper func to create tx * remove unused * update tx cfg * fix cli tests * added simulations * Add `decoder.go` * fix build fail * added init genesis code * update tx.go * fixed LGTM alert * modified cli * remove gogoproto extensions * change acc address type to string * lint * fix simulations * Add gen simulations * remove legacy querier * remove legacy code * add grpc queries tests * fix simulations * update module.go * lint * register feegrant NewSimulationManager * fix sims * fix sims * add genesis test * add periodic grant * updated cmd * changed times * updated flags * removed days as period clock * added condition for period and exp * add periodic fee cli tests * udpated tests * fix lint * fix tests * fix sims * renaming to `fee_grant` * review changes * fix test * add condition for duplicate grants * fix tests * add `genTxWithFeeGranter` in tests * fix simulation * one of changes & test fixes * fix test * fix lint * changed package name `feegrant` to `fee_grant` * review comments * review changes * review change * review changes * added fee-account in flags * address review changes * read fee granter from cli * updated create account with mnemonic * Address review comments * move `simapp/ante` file to `feegrant/ante` * update keeper logic to create account * update docs * fix tests * update `serviceMsgClientConn` from `msgservice` * review changes * add test case for using more fees than allowed * eliminate panic checks from keeper * fix lint * change store keys string to bytes * fix tests * review changes * review changes * udpate docs * make spend limit optional * fix tests * fix tests * review changes * add norace tag * proto-docs * add docs Co-authored-by: Ethan Frey <[email protected]> Co-authored-by: Alexander Bezobchuk <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: SaReN <[email protected]> Co-authored-by: aleem1413 <[email protected]> Co-authored-by: MD Aleem <[email protected]> Co-authored-by: Anil Kumar Kammari <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Sahith Reddy Narahari and others added 4 commits March 10, 2020 20:59

Migrated feegrant concrete types to protobuf

addccaa

Modified periodic fee to take values over pointers

9536fe4

Added godoc

6d1b397

Migrated FeeAllowanceGrant to protobuf

60e328b

Migrated feegrant keeper to protobuf

8a65766

Modified grant

26e470b

Modified tests in feegrant

1f676a8

Sahith Reddy Narahari added 2 commits March 17, 2020 19:58

Added fee grant interfaces

1fe2ebb

Added fee grant interfaces to std

59eef6c

Sahith Reddy Narahari and others added 5 commits March 18, 2020 16:09

Added fee grant interfaces to std

b86df9c

Fix cyclic imports

71d5c4c

Modified import alias

f2aa619

Merge branch 'anil/fee-grant-protobuf' of github.com:regen-network/co…

dbdd13b

…smos-sdk into sahith/fee-auth-proto

Fixed proto issues

47dc3bc

Moved types from codec/std to x/feegrant/types

93c2418

clevinson mentioned this pull request Mar 23, 2020

Migrate x/feegrant to proto regen-network/cosmos-sdk#31

Closed

Migrated tests in feegrant/types

2fc60d9

Sahith Reddy Narahari added 5 commits March 26, 2020 22:15

Fixed keeper tests in feegrant

f04b6dc

Fixed build issues

8d94aa6

Fixed proto lint issues

b9e5c13

Fixed tests in feegrant/types

59f5def

Reverted proto modifications

efed08b

sahith-narahari commented Mar 26, 2020

View reviewed changes

x/feegrant/types/types.proto Outdated Show resolved Hide resolved

Added nullable to expiration

a71ed0a

anilcse requested changes Mar 30, 2020

View reviewed changes

Addressed comments

012cd77

sahith-narahari marked this pull request as ready for review March 30, 2020 13:37

sahith-narahari requested review from alessio, fedekunze, hschoenburg and nylira as code owners March 30, 2020 13:37

anilcse approved these changes Mar 30, 2020

View reviewed changes

alexanderbez suggested changes Mar 30, 2020

View reviewed changes

Moved Feeallowance interface to types

cf78511

golangcibot reviewed Mar 30, 2020

View reviewed changes

x/feegrant/types/grant.go Outdated Show resolved Hide resolved

x/feegrant/types/msgs.go Outdated Show resolved Hide resolved

x/feegrant/types/msgs.go Outdated Show resolved Hide resolved

sahith-narahari added 4 commits March 31, 2020 03:02

Removed exported from feegrant

e832740

Fixed golangci issues

0013aec

Fixed lint issues

7deaa9e

Replaced marshal with codec marshal

ce77463

sahith-narahari changed the title ~~WIP: Migrate x/feegrant to proto~~ Migrate x/feegrant to proto Mar 31, 2020

alexanderbez reviewed Apr 6, 2020

View reviewed changes

x/feegrant/keeper/keeper.go Outdated Show resolved Hide resolved

x/feegrant/keeper/keeper.go Outdated Show resolved Hide resolved

Fixed unmarshal usage in keeper

a089d43

alexanderbez approved these changes Apr 7, 2020

View reviewed changes

alexanderbez merged commit f32db1d into cosmos:bez/enable-fee-auth Apr 7, 2020

sahith-narahari deleted the sahith/fee-auth-proto branch April 7, 2020 19:57

clevinson added this to the v0.39 milestone May 4, 2020

aaronc mentioned this pull request Aug 17, 2020

Key Management Meta-issue #7074

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate x/feegrant to proto #5782

Migrate x/feegrant to proto #5782

sahith-narahari commented Mar 10, 2020

lgtm-com bot commented Mar 10, 2020

lgtm-com bot commented Mar 11, 2020

lgtm-com bot commented Mar 11, 2020

lgtm-com bot commented Mar 12, 2020

lgtm-com bot commented Mar 17, 2020

lgtm-com bot commented Mar 18, 2020

lgtm-com bot commented Mar 23, 2020

lgtm-com bot commented Mar 24, 2020

anilcse left a comment

anilcse left a comment

sahith-narahari commented Apr 6, 2020

alexanderbez left a comment

Migrate x/feegrant to proto #5782

Migrate x/feegrant to proto #5782

Conversation

sahith-narahari commented Mar 10, 2020

Description

lgtm-com bot commented Mar 10, 2020

lgtm-com bot commented Mar 11, 2020

lgtm-com bot commented Mar 11, 2020

lgtm-com bot commented Mar 12, 2020

lgtm-com bot commented Mar 17, 2020

lgtm-com bot commented Mar 18, 2020

lgtm-com bot commented Mar 23, 2020

lgtm-com bot commented Mar 24, 2020

anilcse left a comment

Choose a reason for hiding this comment

anilcse left a comment

Choose a reason for hiding this comment

sahith-narahari commented Apr 6, 2020

alexanderbez left a comment

Choose a reason for hiding this comment