Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto: migrate params to hybrid codec #5619

Merged
merged 34 commits into from
Feb 12, 2020
Merged

proto: migrate params to hybrid codec #5619

merged 34 commits into from
Feb 12, 2020

Conversation

tac0turtle
Copy link
Member

work towards moving params to hybrid codec

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

alexanderbez and others added 25 commits February 1, 2020 14:34
@alexanderbez
Migrate staking types to proto
dec703b
@alexanderbez
Use int32 for validator status
31311cb
@alexanderbez
Update staking types
0d2938b
@alexanderbez
Add benchmarks for bech32 pubkey funcs
60dc367
@alexanderbez
Update BondStatus type alias to int32
f0f6f50
@alexanderbez
Remove PubKey proto type
c268a9e
@alexanderbez
Fix unit test
95edc79
@alexanderbez
Update staking keeper
46be4b4
@alexanderbez
Fix staking keeper tests
7503396
@alexanderbez
Update query client
97ac0b5
@alexanderbez
Update staking genesis and app_test
8e84801
@alexanderbez
Update staking handler
c35939a
@alexanderbez
Use Int64Value instead of IntProto
febaae8
@alexanderbez
Updates tests and APIs
5b83d9b
@alexanderbez
Fix iteration
0a904f1
@alexanderbez
Linting
2450409
@alexanderbez
Fix linting
97148e2
@alexanderbez
Merge branch 'master' into bez/5444-staking-proto-enc
da9d51f
@alexanderbez
Add changelog entry
11a0d8b
@alexanderbez
Update changelog entry
db45cfc
@alexanderbez
Merge branch 'master' into bez/5444-staking-proto-enc
c5a7baa
@alexanderbez
Merge branch 'master' into bez/5444-staking-proto-enc
3e1b445
@alexanderbez
Start boilerplate for app-level codec
d31577c
@tac0turtle
init of params
beade6d
@tac0turtle
change to app codec for params, still have one test failing
1b78d65
@tac0turtle tac0turtle added T: State Machine Breaking State machine breaking changes (impacts consensus). WIP C:x/params labels Feb 6, 2020
@tac0turtle tac0turtle changed the title proto: migrate params to hybridcodec proto: migrate params to hybrid codec Feb 6, 2020
@alexanderbez alexanderbez mentioned this pull request Feb 11, 2020
Closed
28 tasks
@alexanderbez alexanderbez marked this pull request as ready for review February 12, 2020 15:49
@alexanderbez alexanderbez added R4R and removed WIP labels Feb 12, 2020
alexanderbez
alexanderbez approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 48d39e3 into master Feb 12, 2020
@alexanderbez alexanderbez deleted the proto/params branch February 12, 2020 16:34
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@tac0turtle
Merge PR cosmos#5619: proto: migrate params to hybrid codec
60fdb0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@fedekunze fedekunze Awaiting requested review from fedekunze

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:x/params T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tac0turtle @alexanderbez