revert to old go-wire #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #548 +/- ##
===========================================
+ Coverage 56.72% 57.16% +0.43%
===========================================
Files 33 33
Lines 1798 1807 +9
===========================================
+ Hits 1020 1033 +13
+ Misses 697 693 -4
Partials 81 81 |
| @@ -0,0 +1,55 @@ | |||
| package wire | |||
There was a problem hiding this comment.
Good idea to make this package here
There was a problem hiding this comment.
Should help ease the upgrade considerably :)
MSalopek
pushed a commit
to MSalopek/cosmos-sdk
that referenced
this pull request
Apr 12, 2024
* pick out v50 slashing logic * run go mod tidy * remove comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another take at PR #504 for issue #547
It's unclear when Tendermint will be updated to new go-wire. In the meantime, let's revert to old go-wire so we can launch testnets with the new SDK!