Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto.Address -> sdk.Address #545

Merged
merged 1 commit into from
Mar 2, 2018
Merged

crypto.Address -> sdk.Address #545

merged 1 commit into from
Mar 2, 2018

Conversation

ebuchman
Copy link
Member

@ebuchman ebuchman commented Mar 2, 2018

Reduce dependence on go-crypto across the codebase by making a type alias in types

@codecov
Copy link

codecov bot commented Mar 2, 2018

Codecov Report

Merging #545 into develop will not change coverage.
The diff coverage is 45%.

@@           Coverage Diff            @@
##           develop     #545   +/-   ##
========================================
  Coverage    56.72%   56.72%           
========================================
  Files           33       33           
  Lines         1798     1798           
========================================
  Hits          1020     1020           
  Misses         697      697           
  Partials        81       81

Copy link
Contributor

@adrianbrink adrianbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebuchman ebuchman merged commit 3a13a64 into develop Mar 2, 2018
@ebuchman ebuchman deleted the bucky/sdk-address branch March 2, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants