Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SECURITY.md #5377

Merged
merged 6 commits into from
Dec 16, 2019
Merged

update SECURITY.md #5377

merged 6 commits into from
Dec 16, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Dec 9, 2019 •
edited
Loading

Closes: #XXX

Description

Updated SECURITY.md with the latest modules, added core packages, linked to bug bounty program and added security contact email.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added T:Docs Changes and features related to documentation. T: Security labels Dec 9, 2019
@fedekunze fedekunze added the R4R label Dec 9, 2019
@fedekunze fedekunze requested review from jaekwon and zmanian December 9, 2019 10:07
alexanderbez
alexanderbez approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze
Copy link
Collaborator Author

I'm going to block this PR until we integrate @jessysaurusrex's comments

@fedekunze fedekunze added the S:blocked Status: Blocked label Dec 10, 2019
@fedekunze fedekunze removed the S:blocked Status: Blocked label Dec 16, 2019
@fedekunze
Copy link
Collaborator Author

@jessysaurusrex I will merge this now bc the content from the modules section is very outdated. Lmk if you want to work together, later on, to make it consistent with Tendermint's SECURITY.md cc: @tessr

@fedekunze fedekunze merged commit b7ec169 into master Dec 16, 2019
@fedekunze fedekunze deleted the update-security branch December 16, 2019 19:24
xiangjianmeng pushed a commit to xiangjianmeng/cosmos-sdk that referenced this pull request Dec 18, 2019
@fedekunze @xiangjianmeng
update SECURITY.md (cosmos#5377)
96e9ebe 
* update SECURITY.md

* add comment on bug report

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@jessysaurusrex jessysaurusrex Awaiting requested review from jessysaurusrex

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@jaekwon jaekwon Awaiting requested review from jaekwon

@zmanian zmanian Awaiting requested review from zmanian

Assignees
No one assigned
Labels
T:Docs Changes and features related to documentation. T: Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedekunze @alexanderbez