Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix MsgEditValidator json tag #5342

Merged
merged 7 commits into from
Dec 3, 2019
Merged

fix MsgEditValidator json tag #5342

merged 7 commits into from
Dec 3, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Nov 26, 2019 •
edited
Loading

fixes #5336

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added R4R T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Nov 26, 2019
@fedekunze
Copy link
Collaborator Author

fedekunze commented Nov 26, 2019 •
edited
Loading

Needs migration update.

EDIT: Actually... Idk if it's required since it's only the msg JSON tag the one that got updated, not the Description type (i.e the msg is not stored in genesis). @alexanderbez can you confirm?

@fedekunze fedekunze removed the R4R label Nov 26, 2019
@fedekunze fedekunze changed the title fix MsgEditValidator json tag DNM: fix MsgEditValidator json tag Nov 26, 2019
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Nov 26, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 26, 2019 •
edited
Loading

Codecov Report

Merging #5342 into master will decrease coverage by 0.01%.
The diff coverage is 14.28%.

@@            Coverage Diff            @@
##           master   #5342      +/-   ##
=========================================
- Coverage   54.81%   54.8%   -0.02%     
=========================================
  Files         311     311              
  Lines       18385   18385              
=========================================
- Hits        10077   10075       -2     
- Misses       7537    7539       +2     
  Partials      771     771

alexanderbez
alexanderbez approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze changed the title DNM: fix MsgEditValidator json tag fix MsgEditValidator json tag Dec 2, 2019
golangcibot
golangcibot reviewed Dec 3, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
@fedekunze fedekunze merged commit b9c40ea into master Dec 3, 2019
@fedekunze fedekunze deleted the fedekunze/5336-fix-editval-json branch December 3, 2019 11:14
xiangjianmeng pushed a commit to xiangjianmeng/cosmos-sdk that referenced this pull request Dec 18, 2019
@fedekunze @xiangjianmeng
fix MsgEditValidator JSON tag (cosmos#5342)
e3f2338 
* add json tag to MsgEditValidator; closes cosmos#5336

* changelog

* Apply suggestions from code review

Co-Authored-By: Alessio Treglia <[email protected]>

* format

* changelog minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@alessio alessio alessio left review comments

@jackzampolin jackzampolin jackzampolin approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

Assignees
No one assigned
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MsgEditValidator json contains uppercase letter
5 participants
@fedekunze @alessio @alexanderbez @jackzampolin @golangcibot