Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keys subcommands to sign and verify arbitrary text payloads. #5066

Closed
wants to merge 1 commit into from

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Sep 18, 2019

Closes: #4581

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio force-pushed the alessio/keys-sign-verify branch from 13ee737 to b375e1d Compare September 18, 2019 23:05
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #5066 into master will increase coverage by 0.09%.
The diff coverage is 78.46%.

@@            Coverage Diff             @@
##           master    #5066      +/-   ##
==========================================
+ Coverage   55.03%   55.13%   +0.09%     
==========================================
  Files         291      293       +2     
  Lines       17838    17903      +65     
==========================================
+ Hits         9817     9870      +53     
- Misses       7314     7319       +5     
- Partials      707      714       +7

@alexanderbez
Copy link
Contributor

alexanderbez commented Sep 19, 2019

Thanks, @alessio but I'm going to close this PR for now. There needs to be a broader discussion and agreement on arbitrary message signing in addition to integration with Ledger.

ref: cosmos/ibc#33

/cc @jackzampolin @cwgoes @zmanian

@alessio alessio deleted the alessio/keys-sign-verify branch September 20, 2019 01:50
@alessio alessio restored the alessio/keys-sign-verify branch November 13, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to sign arbitrary text with cli
2 participants