Simulation docs #5033
Merged
Simulation docs #5033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start sim |
|
Just a note (not review), there is no
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
keep open |
…dekunze/4534-simulation-docs
fedekunze
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
tac0turtle
approved these changes
Jan 31, 2020
alexanderbez
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
ACK -- great job @fedekunze. Looks very clean. Feel free to merge whenever.
Codecov Report
@@ Coverage Diff @@
## master #5033 +/- ##
=========================================
+ Coverage 53.31% 53.4% +0.08%
=========================================
Files 319 322 +3
Lines 19573 19724 +151
=========================================
+ Hits 10436 10534 +98
- Misses 8317 8373 +56
+ Partials 820 817 -3
|
cwgoes
pushed a commit
that referenced
this pull request
Feb 3, 2020
* simulation docs * update docs with the latest simulation changes * minor imporvments * clean up of simulation.md * expand section on weights * minor reword * minor wording fix Co-authored-by: Marko <[email protected]>
cwgoes
added a commit
that referenced
this pull request
Feb 3, 2020
* Simulation docs (#5033) * simulation docs * update docs with the latest simulation changes * minor imporvments * clean up of simulation.md * expand section on weights * minor reword * minor wording fix Co-authored-by: Marko <[email protected]> * Merge PR #5597: Include Amount in Complete Unbonding/Redelegation Events * Add bank alias for gaia * Moar bank alias gaia * Moar bank alias gaia * Call `TimeoutExecuted`, add wrappers * Remove unused `MsgRecvPacket` Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Alexander Bezobchuk <[email protected]> Co-authored-by: Jack Zampolin <[email protected]>
fedekunze
added a commit
that referenced
this pull request
Feb 20, 2020
* Add comments, remove unused code and attempt to point to places where the spec is being implemented * close channel when transfer fails * rename packer data transfer to align to spec; refactor table tests * ICS 20 implementation cleanup work (#5602) * Simulation docs (#5033) * simulation docs * update docs with the latest simulation changes * minor imporvments * clean up of simulation.md * expand section on weights * minor reword * minor wording fix Co-authored-by: Marko <[email protected]> * Merge PR #5597: Include Amount in Complete Unbonding/Redelegation Events * Add bank alias for gaia * Moar bank alias gaia * Moar bank alias gaia * Call `TimeoutExecuted`, add wrappers * Remove unused `MsgRecvPacket` Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Alexander Bezobchuk <[email protected]> Co-authored-by: Jack Zampolin <[email protected]> * Merge PR #5603: Remove acknowledgement interface in favour of []byte * fixes and cleanup * spec compliance * refactor relay prefixes and tests * Fix test compilation * cleanup; add notes and additional test case * Receive transfer test * Apply suggestions from code review Co-Authored-By: Bot from GolangCI <[email protected]> * Fix autolinter application * Add testcase with incorrect prefix * golangcibot fixes * delete extra comment Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Christopher Goes <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Alexander Bezobchuk <[email protected]> Co-authored-by: Bot from GolangCI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4534
This PR aims to provide a guide to implement the
simulationpackage on each module (module.go), on the application level (app.go) and to create the simulation testing framework (app_test.go).Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: