Implement Gaia Tx Decode #5023
Merged
Implement Gaia Tx Decode #5023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnachen
requested review from
alessio,
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
fedekunze
reviewed
Sep 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #5023 +/- ##
==========================================
- Coverage 55.04% 55.03% -0.02%
==========================================
Files 291 291
Lines 17835 17839 +4
==========================================
Hits 9818 9818
- Misses 7310 7314 +4
Partials 707 707 |
alexanderbez
suggested changes
Sep 10, 2019
tnachen
force-pushed
the
frank/3872-gaiacli-tx-decode-master
branch
from
96776e1 to
57a8696
Compare
alexanderbez
suggested changes
Sep 17, 2019
jackzampolin
approved these changes
Sep 17, 2019
Co-Authored-By: yangyanqing <[email protected]>
Co-Authored-By: yangyanqing <[email protected]>
➜ cosmos-sdk git:(frank/3872-gaiacli-tx-decode-master) ✗ make build
import cycle not allowed
package github.com/cosmos/cosmos-sdk/simapp
imports github.com/cosmos/cosmos-sdk/x/auth
imports github.com/cosmos/cosmos-sdk/x/auth/client/rest
imports github.com/cosmos/cosmos-sdk/x/auth
can't load package: import cycle not allowed
package github.com/cosmos/cosmos-sdk/simapp
imports github.com/cosmos/cosmos-sdk/x/auth
imports github.com/cosmos/cosmos-sdk/x/auth/client/rest
imports github.com/cosmos/cosmos-sdk/x/auth
Makefile:28: recipe for target 'build' failed
make: *** [build] Error 1
Co-Authored-By: Alexander Bezobchuk <[email protected]>
tnachen
force-pushed
the
frank/3872-gaiacli-tx-decode-master
branch
from
87f3ab8 to
f6e7766
Compare
|
@alexanderbez just renamed the file! |
…os/cosmos-sdk into frank/3872-gaiacli-tx-decode-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #3872
This is a resubmission of #4213.
Targeted PR against correct branch (see CONTRIBUTING.md)
[x ] Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
[x ] Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: