-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gaiacli should not panic when user just presses enter during Y/n confirmation #4919
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4919 +/- ##
==========================================
+ Coverage 53.67% 53.68% +0.01%
==========================================
Files 272 272
Lines 17052 17052
==========================================
+ Hits 9152 9154 +2
+ Misses 7210 7208 -2
Partials 690 690 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4919 +/- ##
==========================================
+ Coverage 53.67% 53.68% +0.01%
==========================================
Files 272 272
Lines 17052 17052
==========================================
+ Hits 9152 9154 +2
+ Misses 7210 7208 -2
Partials 690 690 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Please add a bugfix
entry on the changelog.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK -- thanks @haasted :)
Addressing the issue encountered here: e-money/em-ledger#1
If the user does not enter a character in response to the CLI query
confirm transaction before signing and broadcasting [y/N]:
gaiacli will crash with a panic.docs/
)Unreleased
section inCHANGELOG.md
Files changed
in the github PR explorer