refactor crisis tests #4918
refactor crisis tests #4918
Conversation
colin-axner
requested review from
alessio,
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4918 +/- ##
==========================================
+ Coverage 53.75% 53.81% +0.06%
==========================================
Files 272 272
Lines 17103 17117 +14
==========================================
+ Hits 9194 9212 +18
+ Misses 7222 7218 -4
Partials 687 687 |
| return app | ||
| } | ||
|
|
||
| func testPassingInvariant(_ sdk.Context) (string, bool) { |
There was a problem hiding this comment.
what are these for? they don't seem to provide any value other than its name
There was a problem hiding this comment.
they are used in keeper_test.go. I believe it is just there for readability of a passing/failing invariant function
There was a problem hiding this comment.
can we delete them then? 🙏
simapp/test_helpers.go
Outdated
|
|
||
| initCoins := sdk.NewCoins(sdk.NewCoin(app.StakingKeeper.BondDenom(ctx), accAmt)) | ||
| totalSupply := sdk.NewCoins(sdk.NewCoin(app.StakingKeeper.BondDenom(ctx), accAmt.MulRaw(int64(len(testAddrs))))) | ||
| app.SupplyKeeper.SetSupply(ctx, supply.NewSupply(totalSupply)) |
There was a problem hiding this comment.
Do you think think this should be done outside of the function call? Or maybe just added to the total supply instead of simply reseting it?
There was a problem hiding this comment.
Good catch, will add it to the total supply. It can be easy to forget to update supply when writing tests so I think keeping this functionality encapsulated in this helper function will prevent useless debugging
#4875 has merge conflict with #4909
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: