Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DefaultUnbondingTime #4823

Merged
merged 4 commits into from
Jul 31, 2019
Merged

fix DefaultUnbondingTime #4823

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b1d0f0
fix DefaultUnbondingTime
fedekunze Jul 31, 2019
8288c00
update clog
fedekunze Jul 31, 2019
8580180
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into fe…
fedekunze Jul 31, 2019
feb4b96
Update .pending/bugfixes/modules/_fix-defaultunbondin
alexanderbez Jul 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pending/bugfixes/modules/_fix-defaultunbondin
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#4823 update `DefaultUnbondingTime` from 3 days to 3 weeks as specified on the comments
4 changes: 3 additions & 1 deletion x/staking/types/params.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@ import (
"github.com/cosmos/cosmos-sdk/x/params"
)

// Staking params default values
const (
// DefaultUnbondingTime reflects three weeks in seconds as the default
// unbonding time.
// TODO: Justify our choice of default here.
DefaultUnbondingTime time.Duration = time.Second * 60 * 60 * 24 * 3
DefaultUnbondingTime time.Duration = time.Hour * 24 * 7 * 3

// Default maximum number of bonded validators
DefaultMaxValidators uint16 = 100
Expand Down Expand Up @@ -42,6 +43,7 @@ type Params struct {
BondDenom string `json:"bond_denom" yaml:"bond_denom"` // bondable coin denomination
}

// NewParams creates a new Params instance
func NewParams(unbondingTime time.Duration, maxValidators, maxEntries uint16,
bondDenom string) Params {

Expand Down