Colin/supply genesis #4701
Merged
Colin/supply genesis #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While reintroducing the contract tests a little discrepancy was noted:
* type from integer to string in the swagger definition for supply/total/{denominator}
* remove slash from supply/total route in the implementation
colin-axner
requested review from
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## supply-genesis #4701 +/- ##
==================================================
+ Coverage 53.96% 54.07% +0.11%
==================================================
Files 271 271
Lines 17313 17373 +60
==================================================
+ Hits 9343 9395 +52
- Misses 7285 7292 +7
- Partials 685 686 +1 |
5 tasks
|
see comment |
AdityaSripal
approved these changes
Jul 10, 2019
alessio
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this comment. Merged to latest commit of master, then made change in only
migrate.goandtypes.goofx/genaccounts/legacy/v0_36Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: