R4R Staking ValidatorPowerRank to use "Potential Consensus Power" #4524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelrozanski
force-pushed
the
rigel/3985-powerrank-use-tmint-power
branch
from
7a34022 to
4e3c261
Compare
Codecov Report
@@ Coverage Diff @@
## master #4524 +/- ##
==========================================
- Coverage 53.51% 53.48% -0.03%
==========================================
Files 256 257 +1
Lines 16165 16164 -1
==========================================
- Hits 8650 8645 -5
- Misses 6868 6873 +5
+ Partials 647 646 -1 |
int
rigelrozanski
requested review from
alessio,
alexanderbez and
jackzampolin
as code owners
rigelrozanski
changed the title
rigelrozanski
added
ready-for-review
T: State Machine Breaking
rigelrozanski
commented
Jun 10, 2019
| consensusPowerBytes := make([]byte, 8) | ||
| binary.BigEndian.PutUint64(consensusPowerBytes[:], uint64(consensusPower)) | ||
|
|
||
| powerBytes := consensusPowerBytes |
There was a problem hiding this comment.
consolidated keys.go with key.go - but these previous 5 lines are the only code changes in this file
fedekunze
approved these changes
Jun 10, 2019
Co-Authored-By: Federico Kunze <[email protected]>
alessio
reviewed
Jun 10, 2019
alessio
approved these changes
Jun 10, 2019
Co-Authored-By: Alessio Treglia <[email protected]>
5 tasks
alexanderbez
suggested changes
Jun 11, 2019
Co-Authored-By: Alexander Bezobchuk <[email protected]>
….com/cosmos/cosmos-sdk into rigel/3985-powerrank-use-tmint-power
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #4031
gaia ref: cosmos/gaia#41
closes #3985
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: