Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Client Codec Redundancy #4499

Merged
merged 12 commits into from
Jun 6, 2019
Merged

Remove Client Codec Redundancy #4499

merged 12 commits into from
Jun 6, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jun 6, 2019 •
edited
Loading

Do not fret my children due to the size of this PR, for it is merely removing all redundant cdc arguments from client methods and functions.

closes: #4479

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added C:CLI WIP Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Jun 6, 2019
@alexanderbez alexanderbez added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Jun 6, 2019
@alexanderbez alexanderbez marked this pull request as ready for review June 6, 2019 15:11
@alexanderbez alexanderbez requested review from fedekunze and sabau June 6, 2019 15:11
alessio
alessio approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #4499 into master will not change coverage.
The diff coverage is 4.54%.

@@           Coverage Diff           @@
##           master    #4499   +/-   ##
=======================================
  Coverage   53.22%   53.22%           
=======================================
  Files         259      259           
  Lines       16173    16173           
=======================================
  Hits         8608     8608           
  Misses       6919     6919           
  Partials      646      646

@alexanderbez alexanderbez merged commit 3180e68 into master Jun 6, 2019
@alexanderbez alexanderbez deleted the bez/4479-remove-cdc-client-redundency branch June 6, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@fedekunze fedekunze Awaiting requested review from fedekunze

@sabau sabau Awaiting requested review from sabau

Assignees
No one assigned
Labels
C:CLI T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLIContext // Codec
2 participants
@alexanderbez @alessio