Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go-amino v0.15.0 #4342

Merged
merged 2 commits into from
May 15, 2019
Merged

Upgrade to go-amino v0.15.0 #4342

merged 2 commits into from
May 15, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented May 15, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio
Copy link
Contributor

alessio commented May 15, 2019

Please run go mod tidy too and check if go.{mod,sum} get changed - they shouldn't.

@alexanderbez
Copy link
Contributor Author

@alessio this PR is go mod tidy. That's all I ran apart from updating the dep.

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #4342 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4342      +/-   ##
==========================================
+ Coverage   59.37%   59.38%   +0.01%     
==========================================
  Files         214      214              
  Lines       14533    14533              
==========================================
+ Hits         8629     8631       +2     
+ Misses       5266     5264       -2     
  Partials      638      638

@alexanderbez alexanderbez merged commit d8bd7bc into master May 15, 2019
@alexanderbez alexanderbez deleted the bez/upgrade-amino-v0.15.0 branch May 15, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants