Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TruncateDecimal #3913

Merged
merged 5 commits into from
Mar 16, 2019
Merged

Fix TruncateDecimal #3913

merged 5 commits into from
Mar 16, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 15, 2019

closes: #3870
ref: #3909


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #3913 into develop will increase coverage by 0.77%.
The diff coverage is 75%.

@@             Coverage Diff             @@
##           develop    #3913      +/-   ##
===========================================
+ Coverage    60.25%   61.03%   +0.77%     
===========================================
  Files          195      192       -3     
  Lines        14599    14347     -252     
===========================================
- Hits          8796     8756      -40     
+ Misses        5218     5020     -198     
+ Partials       585      571      -14

@alexanderbez alexanderbez marked this pull request as ready for review March 16, 2019 01:31
@alexanderbez
Copy link
Contributor Author

/cc @jaekwon

types/dec_coin.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 5f92fef into develop Mar 16, 2019
@alexanderbez alexanderbez deleted the bez/3870-fix-decimal-coins-trunc branch March 16, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken TruncateDecimal
3 participants