Finalise snapcraft.yaml #3783
Merged
Finalise snapcraft.yaml #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow gaiacli to access host's raw-usb slot. - Promote the package to stable. Closes: #3714
alessio
force-pushed
the
3714-install-raw-usb-plug
branch
from
4d3da4e to
9dcf725
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3783 +/- ##
==========================================
Coverage ? 61.05%
==========================================
Files ? 191
Lines ? 14185
Branches ? 0
==========================================
Hits ? 8661
Misses ? 4970
Partials ? 554 |
cwgoes
reviewed
Mar 2, 2019
| @@ -4,7 +4,7 @@ summary: Gaia Daemon # 79 char long summary | |||
| description: | | |||
| This snap provides the Gaia daemon gaiad and the command line | |||
| tool gaiacli. | |||
| grade: devel # must be 'stable' to release into candidate/stable channels | |||
| grade: stable | |||
There was a problem hiding this comment.
Does this imply that gaia is out of beta?
There was a problem hiding this comment.
It just allows us to promote revisions to candidate/stable when we think it's ready
There was a problem hiding this comment.
This applies to snap, not to Gaia, right?
There was a problem hiding this comment.
This applies to gaia snap packages
cwgoes
approved these changes
Mar 2, 2019
jleni
approved these changes
Mar 2, 2019
|
|
No @jleni, beta is just the channel. Version does not change, I'm happy to elaborate further offline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3714
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: