R4R: Fixing bug in genesis Equal

[jleni]

While working on increasing coverage, I noticed a typo in a possibly critical area.
It does not seem to have an impact at this moment but I would suggest the fix gets applied soon.
I have only included a test for the specific bug/fix. In the next few days, we will increase coverage in other PRs.

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
• Wrote tests
• Updated relevant documentation (docs/)
• Added entries in PENDING.md with issue #
• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[alexanderbez]

wow, good catch @jleni -- is this r4r?

[jleni]

Give me a few minutes, I think I found another problem in the same area.

[jleni]

Yes, the new test reproduces another issue.
Two states with identical proposals are recognized as different.

[jleni]

@alexanderbez It is now ready for review.
But this makes me wonder if there are other similar situations where proposals are not compared correctly, etc. These things will likely surface as we increase coverage.

[cwgoes]

Seems to fail CI.

[alessio]

Brilliant, thanks!

[jleni]

Seems to fail CI.

Yep :| I'll have a look after dinner. I've seen already that integration test sporadically fail. Not sure if this fail is related to the change or not.

[cwgoes]

Seems to fail CI.

Yep :| I'll have a look after dinner. I've seen already that integration test sporadically fail. Not sure if this fail is related to the change or not.

It might not be; I think this is a persistent issue.

[jleni]

Yep, now it passed.
Maybe I can work out tomorrow why that happens.