R4R: Add Vesting Account Genesis Validation #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
| addrStr := acc.Address.String() | ||
|
|
||
| // disallow any duplicate accounts | ||
| if _, ok := addrMap[addrStr]; ok { |
jackzampolin
approved these changes
Jan 29, 2019
Codecov Report
@@ Coverage Diff @@
## develop #3425 +/- ##
===========================================
+ Coverage 59.23% 59.25% +0.01%
===========================================
Files 134 134
Lines 9940 9949 +9
===========================================
+ Hits 5888 5895 +7
- Misses 3678 3681 +3
+ Partials 374 373 -1 |
4 tasks
cwgoes
suggested changes
Jan 29, 2019
Co-Authored-By: alexanderbez <[email protected]>
Co-Authored-By: alexanderbez <[email protected]>
…ion' into bez/3418-vesting-acc-gen-validation
|
Address @cwgoes -- thanks. |
cwgoes
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #3418
partially addresses: #3406
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: