Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: x/auth module spec / code reconciliation #2964

Merged
merged 13 commits into from
Dec 6, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Nov 30, 2018

Closes #2963

This PR

I think x/auth could use some more cleanup on top of this, but I'd like to get an initial spec merged as one of our auditors is waiting on it.

Standard checklist

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes added T:Docs Changes and features related to documentation. spec wip labels Nov 30, 2018
@codecov
Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #2964 into develop will increase coverage by 0.02%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #2964      +/-   ##
===========================================
+ Coverage    55.53%   55.55%   +0.02%     
===========================================
  Files          120      120              
  Lines         8490     8490              
===========================================
+ Hits          4715     4717       +2     
+ Misses        3453     3451       -2     
  Partials       322      322

@cwgoes cwgoes changed the title WIP: x/auth module spec / code reconciliation R4R: x/auth module spec / code reconciliation Dec 4, 2018
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but otherwise, LGTM 👌

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see some spec getting written! Great work @cwgoes!

@jackzampolin jackzampolin merged commit ba5e87c into develop Dec 6, 2018
@jackzampolin jackzampolin deleted the cwgoes/auth-module-spec-code-reconciliation branch December 6, 2018 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/auth module specification
3 participants