-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: x/auth module spec / code reconciliation #2964
R4R: x/auth module spec / code reconciliation #2964
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2964 +/- ##
===========================================
+ Coverage 55.53% 55.55% +0.02%
===========================================
Files 120 120
Lines 8490 8490
===========================================
+ Hits 4715 4717 +2
+ Misses 3453 3451 -2
Partials 322 322 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, but otherwise, LGTM 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see some spec getting written! Great work @cwgoes!
Closes #2963
This PR
x/auth
module spec (will likely need to be unified with [R4R]: Vesting Account(s) Implementation #2694)0x01
instead of"account:"
for efficiency and consistency.I think
x/auth
could use some more cleanup on top of this, but I'd like to get an initial spec merged as one of our auditors is waiting on it.Standard checklist
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: