R4R: gaiad gentx subcommands refactoring #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
alessio
force-pushed
the
alessio/tx-create-validator-refactor
branch
from
90baf04 to
94c6c74
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2874 +/- ##
===========================================
+ Coverage 56.85% 56.86% +0.01%
===========================================
Files 120 120
Lines 8293 8298 +5
===========================================
+ Hits 4715 4719 +4
- Misses 3260 3261 +1
Partials 318 318 |
alessio
changed the title
|
@alessio Looks like |
cwgoes
suggested changes
Nov 21, 2018
4 tasks
alexanderbez
approved these changes
Nov 21, 2018
|
All comments were addressed @alexanderbez @cwgoes, thanks! |
- Replace STDIN/STDOUT redirection in `gaiad gentx` with subcommands command line options to redirect streams to file since viper does not handle redirection well. - Use `BuildCreateValidatorMsg` to build a `MsgCreateValidator` rather than redirecting to `gaiacli tx stake create-validator`. - `PrintUnsignedStdTx` now takes an `io.Writer` object. - Mark `--pubkey`, `--amount` and `--moniker` as required flags instead of validating them manually. - Use stake.NewDescription() to make a new Description - ref #2835
alessio
force-pushed
the
alessio/tx-create-validator-refactor
branch
from
7488178 to
486f65c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace STDIN/STDOUT redirection in
gaiad gentxwith subcommands command line options to redirect streams to file since viper does not handle redirection well.Use
BuildCreateValidatorMsgto build aMsgCreateValidatorrather than redirecting togaiacli tx stake create-validator.PrintUnsignedStdTxnow takes anio.Writerobject.Mark
--pubkey,--amountand--monikeras required flags instead of validating them manually.Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: