WIP: Remove AppInit, other cleanup #2675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaekwon
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
Codecov Report
@@ Coverage Diff @@
## alessio/2596-new-genesis-workflow #2675 +/- ##
=====================================================================
+ Coverage 58.16% 60.71% +2.54%
=====================================================================
Files 153 146 -7
Lines 9476 9074 -402
=====================================================================
- Hits 5512 5509 -3
+ Misses 3604 3206 -398
+ Partials 360 359 -1 |
jaekwon
changed the title
alessio
reviewed
Nov 5, 2018
| @@ -29,19 +29,6 @@ You can edit this `name` later, in the `~/.gaiad/config/config.toml` file: | |||
| moniker = "<your_custom_name>" | |||
| ``` | |||
|
|
|||
| You can edit the `~/.gaiad/config/gaiad.toml` file in order to enable the anti spam mechanism and reject incoming transactions with less than a minimum fee: | |||
There was a problem hiding this comment.
Do we reintroduce this somewhere?
|
Did we want the ability to dynamically adjust the minimum fee without restarting the |
alexanderbez
changed the title
|
@jaekwon looks like this doesn't build. Also, we should add a pending log entry 👍 |
5 tasks
|
This PR is out of date, and Alessio might want to keep server/config somehow. Lets redo this after 0.26.0 is out. NOTE: https://github.com/cosmos/cosmos-sdk/pull/2692/files shuffled some files around, and I've asked Bez to make a followup PR as well. |
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.