-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix changelog for v0.52.0-rc.2
#23502
Conversation
📝 WalkthroughWalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
87-89
: Fix unordered list indentationThe unordered list items under the guidelines section should be indented with 4 spaces instead of 2 spaces to maintain consistent formatting throughout the document.
- * Don't flag issues or omissions in the AI-generated summaries. - * Don't verify the impact of locally-scoped changes on the entire codebase... - * Don't flag unused imports and variables... + * Don't flag issues or omissions in the AI-generated summaries. + * Don't verify the impact of locally-scoped changes on the entire codebase... + * Don't flag unused imports and variables...🧰 Tools
🪛 Markdownlint (0.37.0)
87-87: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
88-88: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
89-89: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md
(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🪛 Markdownlint (0.37.0)
CHANGELOG.md
87-87: Expected: 4; Actual: 2
Unordered list indentation
(MD007, ul-indent)
88-88: Expected: 4; Actual: 2
Unordered list indentation
(MD007, ul-indent)
89-89: Expected: 4; Actual: 2
Unordered list indentation
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: tests (02)
- GitHub Check: build (arm64)
- GitHub Check: build (amd64)
- GitHub Check: dependency-review
- GitHub Check: Summary
🔇 Additional comments (1)
CHANGELOG.md (1)
Line range hint
1-1000
: LGTM! Well-structured changelog documentationThe changelog is well-organized and follows good practices:
- Clear version sections with dates
- Changes categorized by type (Features, Improvements, Bug Fixes, etc.)
- Detailed descriptions with PR references
- Breaking changes clearly marked
🧰 Tools
🪛 Markdownlint (0.37.0)
87-87: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
88-88: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
89-89: Expected: 4; Actual: 2
Unordered list indentation(MD007, ul-indent)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those newly added changes should be deleted from unreleased above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
79-81
: Fix markdown list indentationThe unordered lists in these lines should use 4 spaces for indentation instead of 2 spaces to match the standard markdown formatting.
- * (x/auth) [#5892](https://github.com/cosmos/cosmos-sdk/pull/5892) Add `RegisterKeyTypeCodec` to register new - * (x/bank) [#6536](https://github.com/cosmos/cosmos-sdk/pull/6536) Fix bug in `WriteGeneratedTxResponse` function used by multiple - * (x/genutil) [#5938](https://github.com/cosmos/cosmos-sdk/pull/5938) Fix `InitializeNodeValidatorFiles` error handling. + * (x/auth) [#5892](https://github.com/cosmos/cosmos-sdk/pull/5892) Add `RegisterKeyTypeCodec` to register new + * (x/bank) [#6536](https://github.com/cosmos/cosmos-sdk/pull/6536) Fix bug in `WriteGeneratedTxResponse` function used by multiple + * (x/genutil) [#5938](https://github.com/cosmos/cosmos-sdk/pull/5938) Fix `InitializeNodeValidatorFiles` error handling.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
79-79: Unordered list indentation
Expected: 4; Actual: 2(MD007, ul-indent)
80-80: Unordered list indentation
Expected: 4; Actual: 2(MD007, ul-indent)
81-81: Unordered list indentation
Expected: 4; Actual: 2(MD007, ul-indent)
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md
(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
79-79: Unordered list indentation
Expected: 4; Actual: 2
(MD007, ul-indent)
80-80: Unordered list indentation
Expected: 4; Actual: 2
(MD007, ul-indent)
81-81: Unordered list indentation
Expected: 4; Actual: 2
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (1)
CHANGELOG.md (1)
Line range hint
1-1000
: LGTM! Well-structured changelogThe changelog is well-organized, follows semantic versioning, and provides clear descriptions of changes with proper categorization and PR references. Only minor markdown formatting fixes needed as noted above.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
79-79: Unordered list indentation
Expected: 4; Actual: 2(MD007, ul-indent)
80-80: Unordered list indentation
Expected: 4; Actual: 2(MD007, ul-indent)
81-81: Unordered list indentation
Expected: 4; Actual: 2(MD007, ul-indent)
* main: (61 commits) build(deps): Bump cosmossdk.io/x/tx from 1.0.1 to 1.1.0 (#23547) feat(client/v2): add map support (#23544) fix(db): Fix pebbleDB integration (#23552) build(deps): Bump buf.build/gen/go/cometbft/cometbft/protocolbuffers/go from 1.36.3-20241120201313-68e42a58b301.1 to 1.36.4-20241120201313-68e42a58b301.1 in /api (#23520) build(deps): Bump github.com/golang/glog from 1.2.3 to 1.2.4 in /tools/hubl (#23541) fix(x/tx): add an option to encode maps using amino json (ref #23513) (#23539) build(deps): Bump cosmossdk.io/collections from 1.0.0 to 1.1.0 (#23534) build(deps): Bump github.com/bytedance/sonic from 1.12.7 to 1.12.8 in /log (#23516) chore: fix changelog for `v0.52.0-rc.2` (#23502) build(deps): Bump google.golang.org/protobuf from 1.36.3 to 1.36.4 in /x/upgrade (#23512) chore(collections): bring in `protocodec` in collections directly (#23515) feat(x/tx): add an option to encode maps using amino json (#23513) fix(codec): provide legacy amino og type (#23504) chore: remove unecessary SDKGasMeter impl (#23503) refactor: replace `golang.org/x/exp` with stdlib (#23501) build(deps): Bump google.golang.org/grpc from 1.69.4 to 1.70.0 in /tools/cosmovisor (#23496) build(deps): Bump google.golang.org/grpc from 1.69.4 to 1.70.0 in /store (#23494) build(deps): Bump github.com/hashicorp/go-plugin from 1.6.2 to 1.6.3 in /store (#23493) ci: Fix Ci job target (#23500) feat(server/v2): add swagger server component (#23486) ...
Set's the changelog to be up to date with what was done in the release branch
Summary by CodeRabbit
Release Notes for Cosmos SDK v0.52.0-rc.2
Improvements
Block
field inGetBlockByHeightResponse
Bug Fixes
timeoutTimestamp
in transaction builderRelease Details