-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove baseapp from x/accounts
#23355
Changes from 1 commit
dab4f61
ccdbad4
ef438eb
9dfae05
779bd84
2e7ca6d
6161b6a
7355259
46a30d3
89e5b26
05a8577
f827e73
6c7dc2a
ed63aca
c8b7460
4956083
b5703d4
c7bc69d
1442dc2
9d98953
d29ed65
d42ac1f
a6ffa04
fb55664
87fb4f9
e18d809
4f56126
f67b33f
997bf85
ed61ace
47a681e
9f54324
0cea6dd
1838bbf
31198b6
e932ea5
d17569e
71ad965
4069c71
d759e14
d8b3ac6
150df47
86269ec
ffde8e3
6574b36
b5cf3af
1138fc9
6caaa63
d444dd7
1b9b8f7
eda6e7f
47bdcde
5d14883
615d930
f88a742
a913205
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -7,47 +7,19 @@ toolchain go1.23.4 | |||||
require ( | ||||||
cosmossdk.io/core v1.0.0 | ||||||
github.com/cometbft/cometbft/api v1.0.0 | ||||||
github.com/cosmos/cosmos-sdk v0.50.11 | ||||||
github.com/cosmos/gogoproto v1.7.0 | ||||||
github.com/tidwall/btree v1.7.0 | ||||||
go.uber.org/mock v0.5.0 | ||||||
google.golang.org/grpc v1.69.4 | ||||||
) | ||||||
|
||||||
require ( | ||||||
cosmossdk.io/api v0.7.6 // indirect | ||||||
cosmossdk.io/collections v0.4.0 // indirect | ||||||
cosmossdk.io/errors v1.0.1 // indirect | ||||||
cosmossdk.io/math v1.4.0 // indirect | ||||||
cosmossdk.io/schema v1.0.0 // indirect | ||||||
cosmossdk.io/x/tx v0.13.7 // indirect | ||||||
github.com/btcsuite/btcd/btcec/v2 v2.3.4 // indirect | ||||||
github.com/cometbft/cometbft v0.38.12 // indirect | ||||||
github.com/cosmos/cosmos-proto v1.0.0-beta.5 // indirect | ||||||
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect | ||||||
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.2.0 // indirect | ||||||
github.com/go-kit/log v0.2.1 // indirect | ||||||
github.com/go-logfmt/logfmt v0.6.0 // indirect | ||||||
github.com/golang/protobuf v1.5.4 // indirect | ||||||
github.com/google/go-cmp v0.6.0 // indirect | ||||||
github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect | ||||||
github.com/iancoleman/strcase v0.3.0 // indirect | ||||||
github.com/oasisprotocol/curve25519-voi v0.0.0-20230904125328-1f23a7beb09a // indirect | ||||||
github.com/petermattis/goid v0.0.0-20231207134359-e60b3f734c67 // indirect | ||||||
github.com/pkg/errors v0.9.1 // indirect | ||||||
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect | ||||||
github.com/sasha-s/go-deadlock v0.3.1 // indirect | ||||||
github.com/stretchr/testify v1.9.0 // indirect | ||||||
github.com/tendermint/go-amino v0.16.0 // indirect | ||||||
golang.org/x/crypto v0.28.0 // indirect | ||||||
golang.org/x/exp v0.0.0-20240404231335-c0f41cb1a7a0 // indirect | ||||||
golang.org/x/net v0.30.0 // indirect | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Update golang.org/x/net to patch security vulnerability The current version (v0.30.0) of golang.org/x/net has a high severity vulnerability (GHSA-w32m-9786-jp63) related to non-linear parsing of case-insensitive content in the html package. Please update to a patched version of golang.org/x/net. 🧰 Tools🪛 GitHub Actions: Dependency Review[high] Vulnerable dependency: golang.org/x/[email protected] has a high severity vulnerability related to non-linear parsing of case-insensitive content in golang.org/x/net/html (GHSA-w32m-9786-jp63) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Update golang.org/x/net to patch security vulnerability. The current version (0.30.0) of golang.org/x/net contains a high severity vulnerability (GHSA-w32m-9786-jp63) related to non-linear parsing of case-insensitive content in the HTML package. Update to the latest patched version: - golang.org/x/net v0.30.0 // indirect
+ golang.org/x/net v0.31.0 // indirect 📝 Committable suggestion
Suggested change
🧰 Tools🪛 GitHub Actions: Dependency Review[high] Vulnerable dependency: golang.org/x/[email protected] has a high severity vulnerability related to non-linear parsing of case-insensitive content in golang.org/x/net/html (GHSA-w32m-9786-jp63) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Security: Update golang.org/x/net to patch vulnerability. The current version (v0.30.0) of golang.org/x/net has a high severity vulnerability (GHSA-w32m-9786-jp63) related to non-linear parsing of case-insensitive content in the html package. Please update to a patched version when available. In the meantime, if the html package is not used, this vulnerability may not affect your application. 🧰 Tools🪛 GitHub Actions: Dependency Review[high] Vulnerable dependency: golang.org/x/[email protected] has a high severity vulnerability related to non-linear parsing of case-insensitive content in golang.org/x/net/html (GHSA-w32m-9786-jp63) |
||||||
golang.org/x/sys v0.26.0 // indirect | ||||||
golang.org/x/text v0.19.0 // indirect | ||||||
google.golang.org/genproto v0.0.0-20240227224415-6ceb2ff114de // indirect | ||||||
google.golang.org/genproto/googleapis/api v0.0.0-20241015192408-796eee8c2d53 // indirect | ||||||
google.golang.org/genproto/googleapis/rpc v0.0.0-20241015192408-796eee8c2d53 // indirect | ||||||
google.golang.org/protobuf v1.35.1 // indirect | ||||||
gopkg.in/yaml.v3 v3.0.1 // indirect | ||||||
sigs.k8s.io/yaml v1.4.0 // indirect | ||||||
) |
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,13 +10,16 @@ import ( | |
"testing" | ||
"time" | ||
|
||
"github.com/cosmos/cosmos-sdk/codec" | ||
|
||
"github.com/stretchr/testify/suite" | ||
"go.uber.org/mock/gomock" | ||
|
||
"cosmossdk.io/core/address" | ||
coreevent "cosmossdk.io/core/event" | ||
"cosmossdk.io/core/header" | ||
coretesting "cosmossdk.io/core/testing" | ||
"cosmossdk.io/core/testing/queryclient" | ||
errorsmod "cosmossdk.io/errors" | ||
"cosmossdk.io/log" | ||
"cosmossdk.io/math" | ||
|
@@ -25,7 +28,7 @@ import ( | |
banktestutil "cosmossdk.io/x/bank/testutil" | ||
banktypes "cosmossdk.io/x/bank/types" | ||
|
||
"cosmossdk.io/core/testing/queryclient" | ||
"github.com/cosmos/cosmos-sdk/codec" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove duplicate import of codec package. The codec package is already imported on line 13. This duplicate import is causing the pipeline failures. - "github.com/cosmos/cosmos-sdk/codec" 🧰 Tools🪛 GitHub Actions: Lint[error] 31-31: Variable 'codec' redeclared in this block 🪛 GitHub Actions: Tests / Code Coverage[error] 31-31: Variable 'codec' redeclared in this block There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix duplicate import of 'codec' package. The 'codec' package is imported twice (lines 13 and 31), causing build failures. Remove the duplicate import. - "github.com/cosmos/cosmos-sdk/codec"
🧰 Tools🪛 GitHub Actions: Lint[error] 31-31: Variable 'codec' redeclared in this block 🪛 GitHub Actions: Tests / Code Coverage[error] 31-31: Variable 'codec' redeclared in this block There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove duplicate codec import. The - "github.com/cosmos/cosmos-sdk/codec" 🧰 Tools🪛 GitHub Actions: Lint[error] 31-31: Variable 'codec' redeclared in this block 🪛 GitHub Actions: Tests / Code Coverage[error] 31-31: Variable 'codec' redeclared in this block |
||
codectestutil "github.com/cosmos/cosmos-sdk/codec/testutil" | ||
"github.com/cosmos/cosmos-sdk/runtime" | ||
sdk "github.com/cosmos/cosmos-sdk/types" | ||
|
@@ -186,7 +189,7 @@ func (suite *KeeperTestSuite) SetupTest() { | |
DefaultSendEnabled: banktypes.DefaultDefaultSendEnabled, | ||
})) | ||
|
||
queryHelper := queryclient.NewQueryHelper(encCfg.InterfaceRegistry) | ||
queryHelper := queryclient.NewQueryHelper(codec.NewProtoCodec(encCfg.InterfaceRegistry).GRPCCodec()) | ||
banktypes.RegisterQueryServer(queryHelper, suite.bankKeeper) | ||
banktypes.RegisterInterfaces(encCfg.InterfaceRegistry) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not add this dep however? even if it is the api only, we should try to have core/testing have no dep on cometbft whatsoever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean