fix(systemtests): avoid HTTP server on port 8080 conflict when AddFullnode #22810
Conversation
in TestValidatorDoubleSign
📝 WalkthroughWalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
systemtests/system.go (2)
727-740: Consider adding port availability checks.While the configuration setup is good, consider adding port availability validation before starting the node to prevent runtime failures.
func isPortAvailable(port int) bool { ln, err := net.Listen("tcp", fmt.Sprintf(":%d", port)) if err != nil { return false } ln.Close() return true }
754-754: Add error handling for gRPC port configuration.The gRPC port configuration should include error handling to ensure the port is properly set.
-fmt.Sprintf("--grpc.address=localhost:%d", DefaultGrpcPort+nodeNumber), +grpcPort := DefaultGrpcPort + nodeNumber +if err := validateGrpcPort(grpcPort); err != nil { + return Node{}, fmt.Errorf("invalid gRPC port: %w", err) +} +fmt.Sprintf("--grpc.address=localhost:%d", grpcPort),
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (2)
systemtests/system.go(4 hunks)systemtests/testnet_init.go(2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
systemtests/system.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
systemtests/testnet_init.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
🔇 Additional comments (2)
systemtests/testnet_init.go (1)
150-150: LGTM! Good refactoring of port configuration.
The replacement of hardcoded port values with centralized constants improves maintainability and reduces the risk of port conflicts.
Also applies to: 158-159, 170-171
systemtests/system.go (1)
42-46: LGTM! Well-structured port constant definitions.
The default ports are:
- Well-separated to avoid conflicts
- Follow standard port conventions
- Use clear, descriptive naming
|
Can you add a changelog under systemtests/changelog? Could you name it rc.4 as well with the date of today? |
julienrbrt
changed the title
in TestValidatorDoubleSign
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Bug Fixes
Chores
v1.0.0-rc.4.